fix attrs/args - toString is undefined #1189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getClassName already handles this case
RobbieTheWagner
approved these changes
May 7, 2020
|
@patricklx seems like we had a failing test. I restarted them in case it was a fluke, but may need to look into it. |
| @@ -712,7 +712,7 @@ module('Ember Debug - Object Inspector', function(hooks) { | |||
|
|
|||
| let message = await inspectObject(proxy); | |||
|
|
|||
| assert.ok(message.name.includes('(unknown)')); | |||
| assert.ok(message.name.includes('ObjectProxy'), 'object name should start with <ObjectProxy:'); | |||
There was a problem hiding this comment.
@patricklx Is this the intended output? I suppose it is better than unknown, but just want to make sure things are working as intended.
There was a problem hiding this comment.
yes, since getClassName replaces that part with the class name. But i think it only does it dev builds. in prod it will show unknown again
There was a problem hiding this comment.
Is there not a way to show the same things in both?
There was a problem hiding this comment.
no, since the the class name comes from constructor.name, which will show the uglified value in production
patricklx
added a commit
to patricklx/ember-inspector
that referenced
this pull request
Sep 19, 2022
* fix attrs/args - toString is undefined getClassName already handles this case * object name is now from toString * Update object-inspector-test.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getClassName already handles this case