fix attrs/args - toString is undefined (#1189)

* fix attrs/args - toString is undefined getClassName already handles this case * object name is now from toString * Update object-inspector-test.js
emberjs · May 7, 2020 · ba5f181 · ba5f181
1 parent ec34ccd
commit ba5f181
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/ember_debug/object-inspector.js b/ember_debug/object-inspector.js
@@ -457,7 +457,7 @@ export default EmberObject.extend(PortMixin, {
         parentObject: objectId,
         property,
         objectId: details.objectId,
-        name: object.toString(),
+        name: getClassName(object),
         details: details.mixins,
         errors: details.errors
       });
@@ -471,7 +471,7 @@ export default EmberObject.extend(PortMixin, {
     let details = this.mixinsForObject(object);
     this.sendMessage('updateObject', {
       objectId: details.objectId,
-      name: object.toString(),
+      name: getClassName(object),
       details: details.mixins,
       errors: details.errors
     });

diff --git a/tests/ember_debug/object-inspector-test.js b/tests/ember_debug/object-inspector-test.js
@@ -712,7 +712,7 @@ module('Ember Debug - Object Inspector', function(hooks) {
 
     let message = await inspectObject(proxy);
 
-    assert.ok(message.name.includes('(unknown)'));
+    assert.ok(message.name.includes('ObjectProxy'), 'object name should start with <ObjectProxy:');
 
     assert.equal(message.details[0].name, 'Basic Info');
     assert.equal(message.details[0].properties[0].name, 'name');