Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove TARGET_IE11 flag #7749

Closed
wants to merge 2 commits into from
Closed

Remove TARGET_IE11 flag #7749

wants to merge 2 commits into from

Conversation

snewcomer
Copy link
Contributor

@snewcomer snewcomer commented Nov 9, 2021

ref #7739

While not necessary, further PRs to beta don't need to run on IE11

* Remove TARGET_IE11 flag

* SHOULD_TRANSPILE just like emberjs

* just do all browsers in prod env

* update moar targets
@snewcomer snewcomer added 🎯 beta PR should be backported to beta backport-beta PR targets the beta branch labels Nov 9, 2021
@snewcomer snewcomer self-assigned this Nov 9, 2021
@snewcomer snewcomer added 🏷️ cleanup This PR primarily removes deprecated functionality 🏷️ deprecation and removed 🎯 beta PR should be backported to beta labels Nov 9, 2021
@@ -147,13 +147,9 @@ jobs:
strategy:
fail-fast: false
matrix:
launcher: [Chrome, Firefox, IE]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should still test IE, just not IE11. I believe Edge comes installed on these VMs.

@snewcomer snewcomer closed this Nov 13, 2021
@snewcomer snewcomer deleted the sn/rm-ie11 branch November 13, 2021 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-beta PR targets the beta branch 🏷️ cleanup This PR primarily removes deprecated functionality 🏷️ deprecation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants