Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove TARGET_IE11 flag #7739

Merged
merged 4 commits into from
Nov 5, 2021
Merged

Remove TARGET_IE11 flag #7739

merged 4 commits into from
Nov 5, 2021

Conversation

snewcomer
Copy link
Contributor

@snewcomer snewcomer commented Nov 4, 2021 •
edited
Loading

prep for 4.0!

ref #7724

There are some comments about IE11 in the codebase and features we couldn't use due to lack of APIs. Will follow up after to remove all comments and apply necessary changes.

This PR ultimately aligns our browser targets with ember.js

@snewcomer snewcomer added 🎯 canary PR is targeting canary (default) 🏷️ cleanup This PR primarily removes deprecated functionality labels Nov 4, 2021
@snewcomer snewcomer self-assigned this Nov 4, 2021
snewcomer
snewcomer commented Nov 4, 2021
View reviewed changes
packages/adapter/tests/dummy/config/targets.js Outdated
@@ -2,12 +2,6 @@

const browsers = ['last 1 Chrome versions', 'last 1 Firefox versions', 'last 1 Safari versions'];
Copy link
Contributor Author

@snewcomer snewcomer Nov 4, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we should change this to last 2 across all? Thoughts @igorT ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should do whatever Ember does

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

  browsers = ['last 2 Chrome versions', 'last 2 Firefox versions', 'Safari 12', 'last 2 Edge versions'];

Good idea. Here it is and updated in this PR.

@github-actions
Copy link

github-actions bot commented Nov 4, 2021 •
edited
Loading

Asset Size Report for 6496945

Modern Builds

✅ EmberData shrank by -39.0 B (-38.0 B compressed)

Warnings

⚠️ The uncompressed size of the package ember-inflector has increased by +15.0 B.

Changeset


EmberData +179.02 KB -39.0 B (+38.91 KB -38.0 B compressed)
    @ember-data/store +72.23 KB -7.0 B (+15.7 KB -6.82 B compressed)
        @ember-data/store/-private +71.31 KB -7.0 B (+15.5 KB -6.82 B compressed)
    @ember-data/model +28.55 KB -6.0 B (+6.21 KB -5.85 B compressed)
        @ember-data/model/-private +28.08 KB -6.0 B (+6.1 KB -5.85 B compressed)
    @ember-data/record-data +23.75 KB -13.0 B (+5.16 KB -12.67 B compressed)
        @ember-data/record-data/-private +23.75 KB -13.0 B (+5.16 KB -12.67 B compressed)
    @ember-data/serializer +19.65 KB -3.0 B (+4.27 KB -2.92 B compressed)
        @ember-data/serializer/-private +5.49 KB -2.0 B (+1.19 KB -1.95 B compressed)
        @ember-data/serializer/rest +2.76 KB -1.0 B (+614.49 B -0.97 B compressed)
    @ember-data/adapter +15.96 KB -25.0 B (+3.47 KB -24.36 B compressed)
        @ember-data/adapter/rest +8.11 KB -13.0 B (+1.76 KB -12.67 B compressed)
        @ember-data/adapter/-private +3.76 KB -12.0 B (+836.86 B -11.69 B compressed)
    ember-inflector +6.71 KB +15.0 B (+1.46 KB +14.62 B compressed)
        ember-inflector/lib/system/inflector +2.89 KB +15.0 B (+644.27 B +14.62 B compressed)
Full Asset Analysis (Modern) 

Asset Size Report
=================


Library: EmberData
┌────────────┬─────────────┐
│  (index)   │   Values    │
├────────────┼─────────────┤
│   bytes    │ '179.02 KB' │
│ compressed │ '38.91 KB'  │
│  packages  │      8      │
│  modules   │     44      │
└────────────┴─────────────┘

Package: @ember-data/store
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '72.23 KB' │
│  compressed  │ '15.70 KB' │
│ % Of Library │   '40.3'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/store/-private                        | 71.31 KB  | 15.50 KB   | 98.7          | 39.8
	@ember-data/store/index                           | 936.00 B  | 203.45 B   | 1.3           | 0.5

Package: @ember-data/model
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '28.55 KB' │
│  compressed  │ '6.21 KB'  │
│ % Of Library │   '15.9'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/model/-private                        | 28.08 KB  | 6.10 KB    | 98.3          | 15.7
	@ember-data/model/index                           | 486.00 B  | 105.64 B   | 1.7           | 0.3

Package: @ember-data/record-data
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '23.75 KB' │
│  compressed  │ '5.16 KB'  │
│ % Of Library │   '13.3'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/record-data/-private                  | 23.75 KB  | 5.16 KB    | 100.0         | 13.3

Package: @ember-data/serializer
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '19.65 KB' │
│  compressed  │ '4.27 KB'  │
│ % Of Library │   '11.0'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/serializer/json                       | 7.21 KB   | 1.57 KB    | 36.7          | 4.0
	@ember-data/serializer/-private                   | 5.49 KB   | 1.19 KB    | 27.9          | 3.1
	@ember-data/serializer/json-api                   | 3.73 KB   | 829.47 B   | 19.0          | 2.1
	@ember-data/serializer/rest                       | 2.76 KB   | 614.49 B   | 14.0          | 1.5
	@ember-data/serializer/index                      | 258.00 B  | 56.08 B    | 1.3           | 0.1
	@ember-data/serializer/transform                  | 215.00 B  | 46.73 B    | 1.1           | 0.1

Package: @ember-data/adapter
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '15.96 KB' │
│  compressed  │ '3.47 KB'  │
│ % Of Library │   '8.9'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/adapter/rest                          | 8.11 KB   | 1.76 KB    | 50.8          | 4.5
	@ember-data/adapter/-private                      | 3.76 KB   | 836.86 B   | 23.6          | 2.1
	@ember-data/adapter/error                         | 1.94 KB   | 432.34 B   | 12.2          | 1.1
	@ember-data/adapter/index                         | 1.10 KB   | 244.53 B   | 6.9           | 0.6
	@ember-data/adapter/json-api                      | 1.04 KB   | 232.14 B   | 6.5           | 0.6

Package: ember-data
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '9.36 KB' │
│  compressed  │ '2.03 KB' │
│ % Of Library │   '5.2'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-data/index                                  | 2.42 KB   | 537.76 B   | 25.8          | 1.3
	ember-data/-private                               | 2.12 KB   | 472.12 B   | 22.7          | 1.2
	ember-data/adapters/errors                        | 1.19 KB   | 264.53 B   | 12.7          | 0.7
	ember-data/setup-container                        | 387.00 B  | 84.12 B    | 4.0           | 0.2
	ember-data/relationships                          | 318.00 B  | 69.12 B    | 3.3           | 0.2
	ember-data/serializers/embedded-records-mixin     | 274.00 B  | 59.55 B    | 2.9           | 0.1
	ember-data/serializers/json-api                   | 251.00 B  | 54.55 B    | 2.6           | 0.1
	ember-data/adapters/json-api                      | 245.00 B  | 53.25 B    | 2.6           | 0.1
	ember-data/serializers/json                       | 243.00 B  | 52.82 B    | 2.5           | 0.1
	ember-data/serializers/rest                       | 243.00 B  | 52.82 B    | 2.5           | 0.1
	ember-data/transform                              | 241.00 B  | 52.38 B    | 2.5           | 0.1
	ember-data/adapters/rest                          | 237.00 B  | 51.51 B    | 2.5           | 0.1
	ember-data/serializer                             | 232.00 B  | 50.42 B    | 2.4           | 0.1
	ember-data/adapter                                | 226.00 B  | 49.12 B    | 2.4           | 0.1
	ember-data/model                                  | 222.00 B  | 48.25 B    | 2.3           | 0.1
	ember-data/store                                  | 222.00 B  | 48.25 B    | 2.3           | 0.1
	ember-data/attr                                   | 218.00 B  | 47.38 B    | 2.3           | 0.1
	ember-data/version                                | 162.00 B  | 35.21 B    | 1.7           | 0.1

Package: ember-inflector
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '6.71 KB' │
│  compressed  │ '1.46 KB' │
│ % Of Library │   '3.7'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-inflector/lib/system/inflector              | 2.89 KB   | 644.27 B   | 43.1          | 1.6
	ember-inflector/lib/system/inflections            | 1.59 KB   | 353.65 B   | 23.7          | 0.9
	ember-inflector/index                             | 473.00 B  | 102.81 B   | 6.9           | 0.3
	ember-inflector/lib/system                        | 471.00 B  | 102.38 B   | 6.9           | 0.3
	ember-inflector/lib/helpers/pluralize             | 373.00 B  | 81.07 B    | 5.4           | 0.2
	ember-inflector/lib/utils/make-helper             | 352.00 B  | 76.51 B    | 5.1           | 0.2
	ember-inflector/lib/system/string                 | 318.00 B  | 69.12 B    | 4.6           | 0.2
	ember-inflector/lib/helpers/singularize           | 296.00 B  | 64.34 B    | 4.3           | 0.2

Package: @ember-data/debug
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '2.81 KB'  │
│  compressed  │ '625.15 B' │
│ % Of Library │   '1.6'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/debug/index                           | 2.32 KB   | 516.68 B   | 82.6          | 1.3
	@ember-data/debug/setup                           | 499.00 B  | 108.46 B   | 17.4          | 0.3

Modern Builds (No Rollup)

✅ EmberData shrank by -39.0 B (-55.0 B compressed)

Warnings

⚠️ The uncompressed size of the package ember-inflector has increased by +15.0 B.

Changeset


EmberData +220.62 KB -39.0 B (+42.33 KB -55.0 B compressed)
    @ember-data/store +97.92 KB -7.0 B (+18.79 KB -9.87 B compressed)
        @ember-data/store/-private/system/core-store +17.36 KB -7.0 B (+3.33 KB -9.87 B compressed)
        @ember-data/store/-private/system/model/internal-model +14.44 KB -3.0 B (+2.77 KB -4.23 B compressed)
        @ember-data/store/-private/system/fetch-manager +5.09 KB +2.0 B (+1000.69 B +2.82 B compressed)
        @ember-data/store/-private/system/store/finders +4.57 KB -4.0 B (+897.86 B -5.64 B compressed)
        @ember-data/store/-private/identifiers/cache +3.98 KB -1.0 B (+782.17 B -1.41 B compressed)
        @ember-data/store/-private/system/store/internal-model-factory +2.83 KB +10.0 B (+556.55 B +14.1 B compressed)
        @ember-data/store/-private/system/record-arrays/record-array +2.28 KB -1.0 B (+447.97 B -1.41 B compressed)
        @ember-data/store/-private/system/ds-model-store +1.96 KB +1.0 B (+385.42 B +1.41 B compressed)
        @ember-data/store/-private/system/schema-definition-service +1.51 KB -2.0 B (+296.79 B -2.82 B compressed)
        @ember-data/store/-private/system/references/record +984.0 B +2.0 B (+188.78 B +2.82 B compressed)
        @ember-data/store/-private/system/record-arrays/adapter-populated-record-array +968.0 B +1.0 B (+185.71 B +1.41 B compressed)
        @ember-data/store/-private/system/errors-utils +796.0 B -2.0 B (+152.71 B -2.82 B compressed)
        @ember-data/store/-private/system/coerce-id +494.0 B -2.0 B (+94.77 B -2.82 B compressed)
        @ember-data/store/-private/utils/symbol +392.0 B -1.0 B (+75.2 B -1.41 B compressed)
    @ember-data/model +32.66 KB -6.0 B (+6.27 KB -8.46 B compressed)
        @ember-data/model/-private/model +9.89 KB -2.0 B (+1.9 KB -2.82 B compressed)
        @ember-data/model/-private/system/model-for-mixin +427.0 B -4.0 B (+81.92 B -5.64 B compressed)
    @ember-data/record-data +30.83 KB -13.0 B (+5.91 KB -18.33 B compressed)
        @ember-data/record-data/-private/record-data +8.21 KB +2.0 B (+1.58 KB +2.82 B compressed)
        @ember-data/record-data/-private/graph/-edge-definition +2.81 KB -15.0 B (+552.91 B -21.15 B compressed)
    @ember-data/serializer +22.08 KB -3.0 B (+4.24 KB -4.23 B compressed)
        @ember-data/serializer/-private/embedded-records-mixin +4.39 KB -2.0 B (+861.6 B -2.82 B compressed)
        @ember-data/serializer/rest +2.76 KB -1.0 B (+542.36 B -1.41 B compressed)
    @ember-data/adapter +18.09 KB -25.0 B (+3.47 KB -35.26 B compressed)
        @ember-data/adapter/rest +8.11 KB -13.0 B (+1.56 KB -18.33 B compressed)
        @ember-data/adapter/-private/build-url-mixin +1.93 KB -8.0 B (+378.32 B -11.28 B compressed)
        @ember-data/adapter/-private/utils/serialize-query-params +788.0 B -4.0 B (+151.17 B -5.64 B compressed)
    ember-inflector +6.71 KB +15.0 B (+1.29 KB +21.15 B compressed)
        ember-inflector/lib/system/inflector +2.89 KB +15.0 B (+568.64 B +21.15 B compressed)
Full Asset Analysis (Modern) 

Asset Size Report
=================


Library: EmberData
┌────────────┬─────────────┐
│  (index)   │   Values    │
├────────────┼─────────────┤
│   bytes    │ '220.62 KB' │
│ compressed │ '42.33 KB'  │
│  packages  │      8      │
│  modules   │     149     │
└────────────┴─────────────┘

Package: @ember-data/store
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '97.92 KB' │
│  compressed  │ '18.79 KB' │
│ % Of Library │   '44.4'   │
└──────────────┴────────────┘
	Module                                                                             | Bytes     | Compressed | % of Package  | % Of Library
	--------------------------------------------------------------------------------------------------------------------------------------
	@ember-data/store/-private/system/core-store                                       | 17.36 KB  | 3.33 KB    | 17.7          | 7.9
	@ember-data/store/-private/system/model/internal-model                             | 14.44 KB  | 2.77 KB    | 14.8          | 6.5
	@ember-data/store/-private/system/model/states                                     | 5.44 KB   | 1.04 KB    | 5.6           | 2.5
	@ember-data/store/-private/system/fetch-manager                                    | 5.09 KB   | 1000.69 B  | 5.2           | 2.3
	@ember-data/store/-private/system/store/finders                                    | 4.57 KB   | 897.86 B   | 4.7           | 2.1
	@ember-data/store/-private/system/record-array-manager                             | 4.19 KB   | 822.46 B   | 4.3           | 1.9
	@ember-data/store/-private/identifiers/cache                                       | 3.98 KB   | 782.17 B   | 4.1           | 1.8
	@ember-data/store/-private/index                                                   | 3.57 KB   | 701.21 B   | 3.6           | 1.6
	@ember-data/store/-private/system/store/record-data-store-wrapper                  | 3.41 KB   | 669.17 B   | 3.5           | 1.5
	@ember-data/store/-private/system/snapshot                                         | 3.10 KB   | 609.89 B   | 3.2           | 1.4
	@ember-data/store/-private/system/store/internal-model-factory                     | 2.83 KB   | 556.55 B   | 2.9           | 1.3
	@ember-data/store/-private/system/record-arrays/record-array                       | 2.28 KB   | 447.97 B   | 2.3           | 1.0
	@ember-data/store/-private/system/ds-model-store                                   | 1.96 KB   | 385.42 B   | 2.0           | 0.9
	@ember-data/store/-private/system/request-cache                                    | 1.89 KB   | 370.46 B   | 1.9           | 0.9
	@ember-data/store/-private/system/references/has-many                              | 1.53 KB   | 301.01 B   | 1.6           | 0.7
	@ember-data/store/-private/system/schema-definition-service                        | 1.51 KB   | 296.79 B   | 1.5           | 0.7
	@ember-data/store/-private/system/references/belongs-to                            | 1.32 KB   | 259.76 B   | 1.4           | 0.6
	@ember-data/store/-private/system/model/shim-model-class                           | 1.32 KB   | 258.80 B   | 1.3           | 0.6
	@ember-data/store/-private/system/store/serializer-response                        | 1.14 KB   | 224.08 B   | 1.2           | 0.5
	@ember-data/store/-private/identifiers/utils/uuid-v4                               | 1.05 KB   | 206.81 B   | 1.1           | 0.5
	@ember-data/store/-private/system/references/record                                | 984.00 B  | 188.78 B   | 1.0           | 0.4
	@ember-data/store/-private/system/record-arrays/adapter-populated-record-array     | 968.00 B  | 185.71 B   | 1.0           | 0.4
	@ember-data/store/index                                                            | 936.00 B  | 179.57 B   | 0.9           | 0.4
	@ember-data/store/-private/system/references/reference                             | 934.00 B  | 179.18 B   | 0.9           | 0.4
	@ember-data/store/-private/system/internal-model-map                               | 886.00 B  | 169.97 B   | 0.9           | 0.4
	@ember-data/store/-private/system/errors-utils                                     | 796.00 B  | 152.71 B   | 0.8           | 0.4
	@ember-data/store/-private/system/snapshot-record-array                            | 753.00 B  | 144.46 B   | 0.8           | 0.3
	@ember-data/store/-private/system/record-notification-manager                      | 697.00 B  | 133.72 B   | 0.7           | 0.3
	@ember-data/store/-private/utils/construct-resource                                | 695.00 B  | 133.33 B   | 0.7           | 0.3
	@ember-data/store/-private/system/promise-proxies                                  | 607.00 B  | 116.45 B   | 0.6           | 0.3
	@ember-data/store/-private/system/references                                       | 598.00 B  | 114.72 B   | 0.6           | 0.3
	@ember-data/store/-private/system/store/common                                     | 527.00 B  | 101.10 B   | 0.5           | 0.2
	@ember-data/store/-private/system/coerce-id                                        | 494.00 B  | 94.77 B    | 0.5           | 0.2
	@ember-data/store/-private/system/record-arrays                                    | 487.00 B  | 93.43 B    | 0.5           | 0.2
	@ember-data/store/-private/system/identity-map                                     | 450.00 B  | 86.33 B    | 0.4           | 0.2
	@ember-data/store/-private/ts-interfaces/identifier                                | 400.00 B  | 76.74 B    | 0.4           | 0.2
	@ember-data/store/-private/utils/symbol                                            | 392.00 B  | 75.20 B    | 0.4           | 0.2
	@ember-data/store/-private/system/record-data-for                                  | 390.00 B  | 74.82 B    | 0.4           | 0.2
	@ember-data/store/-private/identifiers/is-stable-identifier                        | 327.00 B  | 62.73 B    | 0.3           | 0.1
	@ember-data/store/-private/ts-interfaces/fetch-manager                             | 316.00 B  | 60.62 B    | 0.3           | 0.1
	@ember-data/store/-private/utils/promise-record                                    | 290.00 B  | 55.63 B    | 0.3           | 0.1
	@ember-data/store/-private/system/backburner                                       | 269.00 B  | 51.60 B    | 0.3           | 0.1
	@ember-data/store/-private/system/deprecated-evented                               | 257.00 B  | 49.30 B    | 0.3           | 0.1
	@ember-data/store/-private/system/normalize-model-name                             | 220.00 B  | 42.20 B    | 0.2           | 0.1
	@ember-data/store/-private/utils/is-non-empty-string                               | 212.00 B  | 40.67 B    | 0.2           | 0.1
	@ember-data/store/-debug/index                                                     | 210.00 B  | 40.28 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/minimum-serializer-interface              | 169.00 B  | 32.42 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/record-data-record-wrapper                | 167.00 B  | 32.03 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/minimum-adapter-interface                 | 166.00 B  | 31.84 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/record-data-store-wrapper                 | 166.00 B  | 31.84 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/schema-definition-service                 | 166.00 B  | 31.84 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/record-data-json-api                      | 161.00 B  | 30.88 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/ember-data-json-api                       | 160.00 B  | 30.69 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/record-data-schemas                       | 160.00 B  | 30.69 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/promise-proxies                           | 156.00 B  | 29.92 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/record-instance                           | 156.00 B  | 29.92 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/record-data                               | 152.00 B  | 29.16 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/ds-model                                  | 149.00 B  | 28.58 B    | 0.1           | 0.1
	@ember-data/store/-private/ts-interfaces/store                                     | 146.00 B  | 28.01 B    | 0.1           | 0.1
	@ember-data/store/-private/ts-interfaces/utils                                     | 146.00 B  | 28.01 B    | 0.1           | 0.1

Package: @ember-data/model
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '32.66 KB' │
│  compressed  │ '6.27 KB'  │
│ % Of Library │   '14.8'   │
└──────────────┴────────────┘
	Module                                                                | Bytes     | Compressed | % of Package  | % Of Library
	-------------------------------------------------------------------------------------------------------------------------
	@ember-data/model/-private/model                                      | 9.89 KB   | 1.90 KB    | 30.3          | 4.5
	@ember-data/model/-private/record-state                               | 6.20 KB   | 1.19 KB    | 19.0          | 2.8
	@ember-data/model/-private/system/promise-many-array                  | 3.80 KB   | 747.25 B   | 11.6          | 1.7
	@ember-data/model/-private/system/many-array                          | 2.85 KB   | 559.82 B   | 8.7           | 1.3
	@ember-data/model/-private/errors                                     | 2.08 KB   | 409.40 B   | 6.4           | 0.9
	@ember-data/model/-private/index                                      | 1.42 KB   | 279.33 B   | 4.4           | 0.6
	@ember-data/model/-private/system/relationships/relationship-meta     | 1.25 KB   | 246.14 B   | 3.8           | 0.6
	@ember-data/model/-private/attr                                       | 857.00 B  | 164.41 B   | 2.6           | 0.4
	@ember-data/model/-private/notify-changes                             | 845.00 B  | 162.11 B   | 2.5           | 0.4
	@ember-data/model/-private/belongs-to                                 | 687.00 B  | 131.80 B   | 2.1           | 0.3
	@ember-data/model/-private/has-many                                   | 648.00 B  | 124.31 B   | 1.9           | 0.3
	@ember-data/model/index                                               | 486.00 B  | 93.23 B    | 1.5           | 0.2
	@ember-data/model/-private/system/promise-belongs-to                  | 447.00 B  | 85.75 B    | 1.3           | 0.2
	@ember-data/model/-private/util                                       | 442.00 B  | 84.79 B    | 1.3           | 0.2
	@ember-data/model/-private/system/diff-array                          | 438.00 B  | 84.03 B    | 1.3           | 0.2
	@ember-data/model/-private/system/model-for-mixin                     | 427.00 B  | 81.92 B    | 1.3           | 0.2

Package: @ember-data/record-data
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '30.83 KB' │
│  compressed  │ '5.91 KB'  │
│ % Of Library │   '14.0'   │
└──────────────┴────────────┘
	Module                                                                            | Bytes     | Compressed | % of Package  | % Of Library
	-------------------------------------------------------------------------------------------------------------------------------------
	@ember-data/record-data/-private/record-data                                      | 8.21 KB   | 1.58 KB    | 26.6          | 3.7
	@ember-data/record-data/-private/graph/index                                      | 4.86 KB   | 954.64 B   | 15.8          | 2.2
	@ember-data/record-data/-private/graph/operations/replace-related-records         | 3.14 KB   | 616.79 B   | 10.2          | 1.4
	@ember-data/record-data/-private/graph/-edge-definition                           | 2.81 KB   | 552.91 B   | 9.1           | 1.3
	@ember-data/record-data/-private/relationships/state/has-many                     | 2.01 KB   | 394.82 B   | 6.5           | 0.9
	@ember-data/record-data/-private/relationships/state/belongs-to                   | 1.92 KB   | 377.75 B   | 6.2           | 0.9
	@ember-data/record-data/-private/graph/operations/update-relationship             | 1.50 KB   | 295.25 B   | 4.9           | 0.7
	@ember-data/record-data/-private/graph/-utils                                     | 1.05 KB   | 206.23 B   | 3.4           | 0.5
	@ember-data/record-data/-private/graph/operations/replace-related-record          | 1.04 KB   | 203.55 B   | 3.4           | 0.5
	@ember-data/record-data/-private/index                                            | 977.00 B  | 187.43 B   | 3.1           | 0.4
	@ember-data/record-data/-private/graph/operations/add-to-related-records          | 788.00 B  | 151.17 B   | 2.5           | 0.3
	@ember-data/record-data/-private/relationships/state/implicit                     | 692.00 B  | 132.76 B   | 2.2           | 0.3
	@ember-data/record-data/-private/graph/operations/remove-from-related-records     | 667.00 B  | 127.96 B   | 2.1           | 0.3
	@ember-data/record-data/-private/coerce-id                                        | 406.00 B  | 77.89 B    | 1.3           | 0.2
	@ember-data/record-data/-private/graph/-state                                     | 293.00 B  | 56.21 B    | 0.9           | 0.1
	@ember-data/record-data/-private/normalize-link                                   | 238.00 B  | 45.66 B    | 0.8           | 0.1
	@ember-data/record-data/-private/ts-interfaces/relationship-record-data           | 171.00 B  | 32.80 B    | 0.5           | 0.1
	@ember-data/record-data/-private/graph/-operations                                | 150.00 B  | 28.77 B    | 0.5           | 0.1

Package: @ember-data/serializer
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '22.08 KB' │
│  compressed  │ '4.24 KB'  │
│ % Of Library │   '10.0'   │
└──────────────┴────────────┘
	Module                                                     | Bytes     | Compressed | % of Package  | % Of Library
	--------------------------------------------------------------------------------------------------------------
	@ember-data/serializer/json                                | 7.21 KB   | 1.38 KB    | 32.7          | 3.3
	@ember-data/serializer/-private/embedded-records-mixin     | 4.39 KB   | 861.60 B   | 19.9          | 2.0
	@ember-data/serializer/json-api                            | 3.73 KB   | 732.10 B   | 16.9          | 1.7
	@ember-data/serializer/rest                                | 2.76 KB   | 542.36 B   | 12.5          | 1.3
	@ember-data/serializer/-private/index                      | 1.18 KB   | 232.13 B   | 5.4           | 0.5
	@ember-data/serializer/-private/transforms/date            | 523.00 B  | 100.33 B   | 2.3           | 0.2
	@ember-data/serializer/-private/transforms/boolean         | 507.00 B  | 97.26 B    | 2.2           | 0.2
	@ember-data/serializer/-private/transforms/number          | 446.00 B  | 85.56 B    | 2.0           | 0.2
	@ember-data/serializer/-private/transforms/string          | 368.00 B  | 70.60 B    | 1.6           | 0.2
	@ember-data/serializer/-private/utils                      | 303.00 B  | 58.13 B    | 1.3           | 0.1
	@ember-data/serializer/index                               | 258.00 B  | 49.49 B    | 1.1           | 0.1
	@ember-data/serializer/-private/transforms/transform       | 257.00 B  | 49.30 B    | 1.1           | 0.1
	@ember-data/serializer/transform                           | 215.00 B  | 41.24 B    | 1.0           | 0.1

Package: @ember-data/adapter
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '18.09 KB' │
│  compressed  │ '3.47 KB'  │
│ % Of Library │   '8.2'    │
└──────────────┴────────────┘
	Module                                                        | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------------------
	@ember-data/adapter/rest                                      | 8.11 KB   | 1.56 KB    | 44.9          | 3.7
	@ember-data/adapter/error                                     | 1.94 KB   | 381.59 B   | 10.7          | 0.9
	@ember-data/adapter/-private/build-url-mixin                  | 1.93 KB   | 378.32 B   | 10.6          | 0.9
	@ember-data/adapter/index                                     | 1.10 KB   | 215.83 B   | 6.1           | 0.5
	@ember-data/adapter/json-api                                  | 1.04 KB   | 204.89 B   | 5.8           | 0.5
	@ember-data/adapter/-private/index                            | 1.03 KB   | 202.59 B   | 5.7           | 0.5
	@ember-data/adapter/-private/utils/serialize-query-params     | 788.00 B  | 151.17 B   | 4.3           | 0.3
	@ember-data/adapter/-private/utils/determine-body-promise     | 566.00 B  | 108.58 B   | 3.1           | 0.3
	@ember-data/adapter/-private/utils/parse-response-headers     | 480.00 B  | 92.08 B    | 2.6           | 0.2
	@ember-data/adapter/-private/utils/fetch                      | 454.00 B  | 87.10 B    | 2.5           | 0.2
	@ember-data/adapter/-private/utils/serialize-into-hash        | 347.00 B  | 66.57 B    | 1.9           | 0.2
	@ember-data/adapter/-private/utils/continue-on-reject         | 222.00 B  | 42.59 B    | 1.2           | 0.1
	@ember-data/adapter/-private/fastboot-interface               | 147.00 B  | 28.20 B    | 0.8           | 0.1

Package: ember-data
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '9.52 KB' │
│  compressed  │ '1.83 KB' │
│ % Of Library │   '4.3'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-data/index                                  | 2.42 KB   | 474.63 B   | 25.4          | 1.1
	ember-data/-private/index                         | 1.93 KB   | 378.71 B   | 20.2          | 0.9
	ember-data/adapters/errors                        | 1.19 KB   | 233.48 B   | 12.5          | 0.5
	ember-data/setup-container                        | 387.00 B  | 74.24 B    | 4.0           | 0.2
	ember-data/-private/core                          | 366.00 B  | 70.21 B    | 3.8           | 0.2
	ember-data/relationships                          | 318.00 B  | 61.00 B    | 3.3           | 0.1
	ember-data/serializers/embedded-records-mixin     | 274.00 B  | 52.56 B    | 2.8           | 0.1
	ember-data/serializers/json-api                   | 251.00 B  | 48.15 B    | 2.6           | 0.1
	ember-data/adapters/json-api                      | 245.00 B  | 47.00 B    | 2.5           | 0.1
	ember-data/serializers/json                       | 243.00 B  | 46.61 B    | 2.5           | 0.1
	ember-data/serializers/rest                       | 243.00 B  | 46.61 B    | 2.5           | 0.1
	ember-data/transform                              | 241.00 B  | 46.23 B    | 2.5           | 0.1
	ember-data/adapters/rest                          | 237.00 B  | 45.46 B    | 2.4           | 0.1
	ember-data/serializer                             | 232.00 B  | 44.50 B    | 2.4           | 0.1
	ember-data/adapter                                | 226.00 B  | 43.35 B    | 2.3           | 0.1
	ember-data/model                                  | 222.00 B  | 42.59 B    | 2.3           | 0.1
	ember-data/store                                  | 222.00 B  | 42.59 B    | 2.3           | 0.1
	ember-data/attr                                   | 218.00 B  | 41.82 B    | 2.2           | 0.1
	ember-data/version                                | 162.00 B  | 31.07 B    | 1.7           | 0.1

Package: ember-inflector
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '6.71 KB' │
│  compressed  │ '1.29 KB' │
│ % Of Library │   '3.0'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-inflector/lib/system/inflector              | 2.89 KB   | 568.64 B   | 43.1          | 1.3
	ember-inflector/lib/system/inflections            | 1.59 KB   | 312.14 B   | 23.7          | 0.7
	ember-inflector/index                             | 473.00 B  | 90.74 B    | 6.9           | 0.2
	ember-inflector/lib/system                        | 471.00 B  | 90.36 B    | 6.9           | 0.2
	ember-inflector/lib/helpers/pluralize             | 373.00 B  | 71.56 B    | 5.4           | 0.2
	ember-inflector/lib/utils/make-helper             | 352.00 B  | 67.53 B    | 5.1           | 0.2
	ember-inflector/lib/system/string                 | 318.00 B  | 61.00 B    | 4.6           | 0.1
	ember-inflector/lib/helpers/singularize           | 296.00 B  | 56.78 B    | 4.3           | 0.1

Package: @ember-data/debug
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '2.81 KB'  │
│  compressed  │ '551.76 B' │
│ % Of Library │   '1.3'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/debug/index                           | 2.32 KB   | 456.02 B   | 82.6          | 1.1
	@ember-data/debug/setup                           | 499.00 B  | 95.73 B    | 17.4          | 0.2

@snewcomer snewcomer force-pushed the sn/remove-target-ie11 branch from 2592588 to 98c2bbb Compare November 5, 2021 00:10
@github-actions
Copy link

github-actions bot commented Nov 5, 2021 •
edited
Loading

Performance Report for 6496945

Scenario - materialization: ☑️ Performance is stable

☑️ duration
phase no difference [-40ms to 21ms]
☑️ Phase [navigationStart] => [start-find-all]
phase no difference [-13ms to 15ms]
☑️ Phase [start-find-all] => [start-materialization]
phase no difference [-27ms to 13ms]
☑️ Phase [start-materialization] => [end-materialization]
phase no difference [-7ms to 10ms]
☑️ Phase [end-materialization] => [Test End]
phase no difference [-9ms to 6ms]

Scenario - unload: ☑️ Performance is stable

☑️ duration
phase no difference [-18ms to 37ms]
☑️ Phase [navigationStart] => [start-push-payload]
phase no difference [-9ms to 13ms]
☑️ Phase [start-push-payload] => [start-unload-records]
phase no difference [-21ms to 19ms]
☑️ Phase [start-unload-records] => [end-unload-records]
phase no difference [-4ms to 9ms]
☑️ Phase [end-unload-records] => [Test End]
phase no difference [-1ms to 3ms]

Scenario - destroy: ☑️ Performance is stable

☑️ duration
phase no difference [-21ms to 30ms]
☑️ Phase [navigationStart] => [start-push-payload]
phase no difference [-7ms to 11ms]
☑️ Phase [start-push-payload] => [start-destroy-records]
phase no difference [-8ms to 25ms]
☑️ Phase [start-destroy-records] => [end-destroy-records]
phase no difference [-11ms to 8ms]
☑️ Phase [end-destroy-records] => [Test End]
phase no difference [-2ms to 1ms]

Scenario - add-children: ☑️ Performance is stable

☑️ duration
phase no difference [-13ms to 24ms]
☑️ Phase [navigationStart] => [start-push-initial-payload]
phase no difference [-16ms to 7ms]
☑️ Phase [start-push-initial-payload] => [start-push-update-payload]
phase no difference [0ms to 19ms]
☑️ Phase [start-push-update-payload] => [end-push-update-payload]
phase no difference [-2ms to 6ms]
☑️ Phase [end-push-update-payload] => [Test End]
phase no difference [-3ms to 2ms]

Scenario - unused-relationships: ☑️ Performance is stable

☑️ duration
phase no difference [-17ms to 27ms]
☑️ Phase [navigationStart] => [start-push-payload]
phase no difference [-20ms to 0ms]
☑️ Phase [start-push-payload] => [end-push-payload]
phase no difference [-4ms to 32ms]
☑️ Phase [end-push-payload] => [Test End]
phase no difference [-5ms to 2ms]

@snewcomer snewcomer force-pushed the sn/remove-target-ie11 branch from 9e2b604 to cbcf812 Compare November 5, 2021 01:46
@snewcomer snewcomer force-pushed the sn/remove-target-ie11 branch from cbcf812 to 1cf600b Compare November 5, 2021 01:51
@igorT
Copy link
Member

igorT commented Nov 5, 2021

@snewcomer looks like lint is failing

@snewcomer snewcomer force-pushed the sn/remove-target-ie11 branch from 941142b to 6496945 Compare November 5, 2021 02:41
@snewcomer snewcomer merged commit 85756e0 into master Nov 5, 2021
@delete-merged-branch delete-merged-branch bot deleted the sn/remove-target-ie11 branch November 5, 2021 03:28
snewcomer added a commit that referenced this pull request Nov 9, 2021
@snewcomer
Remove TARGET_IE11 flag (#7739)
7a7c247 
* Remove TARGET_IE11 flag

* SHOULD_TRANSPILE just like emberjs

* just do all browsers in prod env

* update moar targets
@snewcomer snewcomer mentioned this pull request Nov 9, 2021
Closed
snewcomer added a commit that referenced this pull request Nov 21, 2021
@snewcomer
Remove TARGET_IE11 flag (#7739)
1eb0561 
* Remove TARGET_IE11 flag

* SHOULD_TRANSPILE just like emberjs

* just do all browsers in prod env

* update moar targets
snewcomer added a commit that referenced this pull request Nov 21, 2021
@snewcomer
Remove TARGET_IE11 flag (#7739)
85269c9 
* Remove TARGET_IE11 flag

* SHOULD_TRANSPILE just like emberjs

* just do all browsers in prod env

* update moar targets
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igorT igorT igorT approved these changes

Assignees

@snewcomer snewcomer

Labels
🎯 canary PR is targeting canary (default) 🏷️ cleanup This PR primarily removes deprecated functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@snewcomer @igorT