Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix creation recursion with ember-data-model-fragments #7123

Merged
merged 3 commits into from
Apr 10, 2020

Conversation

BryanCrotaz
Copy link
Contributor

Lazily create transforms in core-store constructor by checking for factoryFor, instead of lookup

@runspired runspired merged commit bdd96dd into emberjs:master Apr 10, 2020
@runspired runspired added 🏷️ bug This PR primarily fixes a reported issue 🎯 beta PR should be backported to beta 🎯 lts The PR should be backported to the most recent LTS 🎯 release PR should be backported to release labels Apr 10, 2020
@BryanCrotaz
Copy link
Contributor Author

Can this be backported to 3.17?

@runspired
Copy link
Contributor

@BryanCrotaz yes, that is the target:release label :)

@BryanCrotaz
Copy link
Contributor Author

@BryanCrotaz yes, that is the target:release label :)

How does that process work? What's the likely timing?

I'm having trouble using my branch in my projects - yarn issues because there's no version in the package.json.

@runspired
Copy link
Contributor

@BryanCrotaz release week is this week so sometime this week, hopefully today or tomorrow

@BryanCrotaz
Copy link
Contributor Author

Any chance of that being today? I can't ship without it.

@BryanCrotaz
Copy link
Contributor Author

I've tried branching and adding a version to the package.json, and putting my branch in dependencies and resolutions for my app. However my addons (e.g. ember-local-storage) are complaining that they can't find the ember-data module.

Please could we get a 3.17.1 release with this PR?

@runspired
Copy link
Contributor

@BryanCrotaz 3.16 LTS is on it's way out with this

@runspired runspired removed the 🎯 lts The PR should be backported to the most recent LTS label Apr 24, 2020
@runspired runspired mentioned this pull request Apr 24, 2020
@runspired
Copy link
Contributor

@BryanCrotaz 3.17.1 is also on it's way out the door <3

@runspired runspired removed the 🎯 release PR should be backported to release label Apr 25, 2020
@runspired runspired mentioned this pull request Apr 25, 2020
@runspired
Copy link
Contributor

@BryanCrotaz will also be included in the 3.18 and 3.19 beta and 3.20 canary releases

@BryanCrotaz
Copy link
Contributor Author

YAY! Thanks so much!

runspired added a commit that referenced this pull request Apr 28, 2020
* [BUGFIX] dont use Ember.get on internals (#7103)

* chore: update lts tests (#7133)

* clear relationships during delete (#7109)

* clear initialState after construction (#7110)

* fix creation recursion with ember-data-model-fragments (#7123)

* fix: blueprint tests for classic (#7132)

* fix: blueprint tests for classic

* fix lint

* fix: skip tracked test for older ember versions

* fix lint

* cleanup yarn install

Co-authored-by: pieter-v <[email protected]>
Co-authored-by: Bryan <[email protected]>
runspired added a commit that referenced this pull request Apr 28, 2020
* [BUGFIX] dont use Ember.get on internals (#7103)

* chore: update lts tests (#7133)

* clear relationships during delete (#7109)

* clear initialState after construction (#7110)

* fix creation recursion with ember-data-model-fragments (#7123)

* fix: blueprint tests for classic (#7132)

* fix: blueprint tests for classic

* fix lint

* fix: skip tracked test for older ember versions

* fix lint

* cleanup yarn install

Co-authored-by: pieter-v <[email protected]>
Co-authored-by: Bryan <[email protected]>
runspired added a commit that referenced this pull request Apr 28, 2020
* [BUGFIX] dont use Ember.get on internals (#7103)

* chore: update lts tests (#7133)

* clear relationships during delete (#7109)

* clear initialState after construction (#7110)

* fix creation recursion with ember-data-model-fragments (#7123)

* fix: blueprint tests for classic (#7132)

* fix: blueprint tests for classic

* fix lint

* fix: skip tracked test for older ember versions

* fix lint

* cleanup yarn install

* fix lts

Co-authored-by: pieter-v <[email protected]>
Co-authored-by: Bryan <[email protected]>
@igorT igorT removed the 🎯 beta PR should be backported to beta label Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bug This PR primarily fixes a reported issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants