-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix creation recursion with ember-data-model-fragments #7123
Conversation
Can this be backported to 3.17? |
@BryanCrotaz yes, that is the |
How does that process work? What's the likely timing? I'm having trouble using my branch in my projects - yarn issues because there's no |
@BryanCrotaz release week is this week so sometime this week, hopefully today or tomorrow |
Any chance of that being today? I can't ship without it. |
I've tried branching and adding a version to the package.json, and putting my branch in dependencies and resolutions for my app. However my addons (e.g. ember-local-storage) are complaining that they can't find the ember-data module. Please could we get a 3.17.1 release with this PR? |
@BryanCrotaz 3.16 LTS is on it's way out with this |
@BryanCrotaz 3.17.1 is also on it's way out the door <3 |
@BryanCrotaz will also be included in the 3.18 and 3.19 beta and 3.20 canary releases |
YAY! Thanks so much! |
* [BUGFIX] dont use Ember.get on internals (#7103) * chore: update lts tests (#7133) * clear relationships during delete (#7109) * clear initialState after construction (#7110) * fix creation recursion with ember-data-model-fragments (#7123) * fix: blueprint tests for classic (#7132) * fix: blueprint tests for classic * fix lint * fix: skip tracked test for older ember versions * fix lint * cleanup yarn install Co-authored-by: pieter-v <[email protected]> Co-authored-by: Bryan <[email protected]>
* [BUGFIX] dont use Ember.get on internals (#7103) * chore: update lts tests (#7133) * clear relationships during delete (#7109) * clear initialState after construction (#7110) * fix creation recursion with ember-data-model-fragments (#7123) * fix: blueprint tests for classic (#7132) * fix: blueprint tests for classic * fix lint * fix: skip tracked test for older ember versions * fix lint * cleanup yarn install Co-authored-by: pieter-v <[email protected]> Co-authored-by: Bryan <[email protected]>
* [BUGFIX] dont use Ember.get on internals (#7103) * chore: update lts tests (#7133) * clear relationships during delete (#7109) * clear initialState after construction (#7110) * fix creation recursion with ember-data-model-fragments (#7123) * fix: blueprint tests for classic (#7132) * fix: blueprint tests for classic * fix lint * fix: skip tracked test for older ember versions * fix lint * cleanup yarn install * fix lts Co-authored-by: pieter-v <[email protected]> Co-authored-by: Bryan <[email protected]>
Lazily create transforms in core-store constructor by checking for factoryFor, instead of lookup