clear relationships during delete #7109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This also fixes the failing test defined in #6600 |
runspired
approved these changes
Apr 6, 2020
runspired
added
🎯 beta
runspired
pushed a commit
that referenced
this pull request
Apr 24, 2020
Merged
runspired
pushed a commit
that referenced
this pull request
Apr 24, 2020
Merged
runspired
pushed a commit
that referenced
this pull request
Apr 25, 2020
Merged
runspired
added a commit
that referenced
this pull request
Apr 28, 2020
* [BUGFIX] dont use Ember.get on internals (#7103) * chore: update lts tests (#7133) * clear relationships during delete (#7109) * clear initialState after construction (#7110) * fix creation recursion with ember-data-model-fragments (#7123) * fix: blueprint tests for classic (#7132) * fix: blueprint tests for classic * fix lint * fix: skip tracked test for older ember versions * fix lint * cleanup yarn install Co-authored-by: pieter-v <[email protected]> Co-authored-by: Bryan <[email protected]>
runspired
added a commit
that referenced
this pull request
Apr 28, 2020
* [BUGFIX] dont use Ember.get on internals (#7103) * chore: update lts tests (#7133) * clear relationships during delete (#7109) * clear initialState after construction (#7110) * fix creation recursion with ember-data-model-fragments (#7123) * fix: blueprint tests for classic (#7132) * fix: blueprint tests for classic * fix lint * fix: skip tracked test for older ember versions * fix lint * cleanup yarn install Co-authored-by: pieter-v <[email protected]> Co-authored-by: Bryan <[email protected]>
runspired
added a commit
that referenced
this pull request
Apr 28, 2020
* [BUGFIX] dont use Ember.get on internals (#7103) * chore: update lts tests (#7133) * clear relationships during delete (#7109) * clear initialState after construction (#7110) * fix creation recursion with ember-data-model-fragments (#7123) * fix: blueprint tests for classic (#7132) * fix: blueprint tests for classic * fix lint * fix: skip tracked test for older ember versions * fix lint * cleanup yarn install * fix lts Co-authored-by: pieter-v <[email protected]> Co-authored-by: Bryan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While investigating memory usage of our application, where we load a large amount of data and afterwards destroy/unload it again, I noticed that the
recordDataobjects are not destroyed and kept consuming memory. I tracked it down toRelationshipsnot being cleared during unload.