-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CHORE] add package flag infra, strip flag infra #6737
Conversation
1dbbf04
to
fa4c9fa
Compare
fa4c9fa
to
c3affc0
Compare
Asset Size Report for c3affc0 EmberData shrank by 1.46 KB (438.0 B compressed)If any packages had changed sizes they would be listed here. Changeset
Full Asset Analysis
|
c3affc0
to
d44e9b5
Compare
Asset Size Report for d44e9b5 EmberData shrank by 17.51 KB (3.36 KB compressed)If any packages had changed sizes they would be listed here. Changeset
Full Asset Analysis
|
Asset Size Report for 3420282 EmberData shrank by 17.51 KB (3.36 KB compressed)If any packages had changed sizes they would be listed here. Changeset
Full Asset Analysis
|
e7d7f5f
to
94a56f0
Compare
Asset Size Report for 56c404e EmberData shrank by 17.45 KB (3.36 KB compressed)If any packages had changed sizes they would be listed here. Changeset
Full Asset Analysis
|
Asset Size Report for b9bd1c8 EmberData shrank by 17.45 KB (3.36 KB compressed)If any packages had changed sizes they would be listed here. Changeset
Full Asset Analysis
|
Seems like this needs TS review, added a label |
Asset Size Report for 7c8f35d EmberData shrank by 17.45 KB (3.36 KB compressed)If any packages had changed sizes they would be listed here. Changeset
Full Asset Analysis
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢
Asset Size Report for 3a75acc EmberData shrank by 17.45 KB (3.36 KB compressed)If any packages had changed sizes they would be listed here. Changeset
Full Asset Analysis
|
Asset Size Report for 3dc78d4 EmberData shrank by 17.45 KB (3.36 KB compressed)If any packages had changed sizes they would be listed here. Changeset
Full Asset Analysis
|
Asset Size Report for e963efd EmberData shrank by 17.45 KB (3.36 KB compressed)If any packages had changed sizes they would be listed here. Changeset
Full Asset Analysis
|
packages/private-build-infra/src/addon-build-config-for-data-package.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with those tweaks
convert to flag infra dont ship flag code to production
8576840
to
9f2fb21
Compare
Asset Size Report for 9f2fb21 EmberData shrank by 17.45 KB (3.36 KB compressed)If any packages had changed sizes they would be listed here. Changeset
Full Asset Analysis
|
resolves #6709
With this we use build time flags instead of runtime heuristics for wrapping conditional code for optional-package dependencies. This reduces the cost of supporting those packages.
We also now drop the feature-flag modules from production builds entirely, which saves us some additional bytes :)
Additionally this fixes stripping dead import statements, which apparently was silently broken due to how more recent versions of plugins in our build interop. Asset size monitoring should help to watch for that in the future.
Our asset-size checks currently do not report the size of packages like
store
whenmodel
adapter
andserializer
are removed, but this likely ought to have an additional effect between .5-1 KB currently in addition to the wins from import-stripping and module-dropping that this PR brings.