Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move @ember-data/ package detection to build time #6709

Closed
runspired opened this issue Nov 9, 2019 · 0 comments · Fixed by #6737
Closed

Move @ember-data/ package detection to build time #6709

runspired opened this issue Nov 9, 2019 · 0 comments · Fixed by #6737
Labels
Infra/CI/DX 🌲 Project Trim 🌲 PRs related to https://github.com/emberjs/data/issues/6166

Comments

@runspired
Copy link
Contributor

Currently for deprecations and encapsulation we rely on the detection of the presence of @ember-data/<packageName> via a check on require.has at runtime. We should switch these flags to being imports that are injected at build-time and eliminated via our conventional flag stripping infra. Ember compatibility helpers is a great example library for how to achieve this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infra/CI/DX 🌲 Project Trim 🌲 PRs related to https://github.com/emberjs/data/issues/6166
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant