[DEPRECATION] RFC-522 implementation to add deprecations

[pete-the-pete]

RFC-522 implementation to add deprecations for default serializers and adapters.

NOTE: this is an initial commit; refinements and test changes coming

Deprecation Docs: ember-learn/deprecation-app#436

[rwjblue]

Can you update the deprecate calls here to include a url property that links to the deprecation guides that you are working to add over in https://github.com/ember-learn/deprecation-app/tree/master/content/ember-data/v3?

I think it should also add some deprecation tests (to ensure the deprecations are fired in the right circumstances).

[pete-the-pete]

Yep...working on it.

…

On Thu, Aug 29, 2019 at 8:07 AM Robert Jackson ***@***.***> wrote: ***@***.**** commented on this pull request. Can you update the deprecate calls here to include a url property that links to the deprecation guides that you are working to add over in https://github.com/ember-learn/deprecation-app/tree/master/content/ember-data/v3 ? I think it should also add some deprecation tests (to ensure the deprecations are fired in the right circumstances). — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#6390?email_source=notifications&email_token=AACUPAOEJNVQ7ODRIREZVQDQG7Q25A5CNFSM4IRYXXFKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCDD4L3I#pullrequestreview-281527789>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AACUPAISI53DV6TNBIHG64TQG7Q25ANCNFSM4IRYXXFA> .

[pete-the-pete]

Small update to add deprecatedTest and remove some deprecations.

@rwjblue I didn't see other deprecations with the url prop, can you point me to an example?
I'm on vacation now, but will have time to work on this a little over the next few days.

[rwjblue]

Here is an example from ember-source:

https://github.com/emberjs/ember.js/blob/f73d8440d19cf86a10c61ddb89d45881acfcf974/packages/%40ember/-internals/console/index.js#L44-L48

The Ember Inspector, the deprecation workflow, and the Ember.deprecate console logging shows this URL when the deprecation is triggered. It helps folks know what to do (and understand the deprecation a bit more).

[pete-the-pete]

Here is an example from ember-source:

https://github.com/emberjs/ember.js/blob/f73d8440d19cf86a10c61ddb89d45881acfcf974/packages/%40ember/-internals/console/index.js#L44-L48

The Ember Inspector, the deprecation workflow, and the Ember.deprecate console logging shows this URL when the deprecation is triggered. It helps folks know what to do (and understand the deprecation a bit more).

@rwjblue I added links to the docs I created here: ember-learn/deprecation-app#436

[runspired]

Overall looks good on the implementation but the descriptions need some more work

[runspired]

Almost there! :)

[rwjblue]

I just landed ember-learn/deprecation-app#436 (thank you for the hard work!), can you confirm that the published deprecation URLs match the ones we have here?

[runspired]

Added updates for URLs

[pete-the-pete]

Added updates for URLs

🙇