Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC-0522 Ember-Data Deprecate default serializers and adapters #436

Merged

Conversation

pete-the-pete
Copy link
Contributor

Adding deprecation documentation for RFC-0522

Copy link
Contributor

@rwjblue rwjblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this!

content/ember-data/v3/default-adapter.md Outdated Show resolved Hide resolved
content/ember-data/v3/default-serializer.md Outdated Show resolved Hide resolved
content/ember-data/v3/default-serializer.md Outdated Show resolved Hide resolved
content/ember-data/v3/toJSON.md Outdated Show resolved Hide resolved
@rwjblue
Copy link
Contributor

rwjblue commented Sep 10, 2019

Also, cc @runspired for visibility / review.

@pete-the-pete
Copy link
Contributor Author

Thanks for working on this!

👍 Thanks for reviewing and offering suggestions. i'll put some time into this now.

content/ember-data/v3/default-adapter.md Outdated Show resolved Hide resolved
content/ember-data/v3/default-serializer.md Outdated Show resolved Hide resolved
@pete-the-pete pete-the-pete force-pushed the default-serializers-and-adapters branch from 88fee87 to 4653a50 Compare September 12, 2019 19:41
@pete-the-pete pete-the-pete force-pushed the default-serializers-and-adapters branch from e4bd263 to c861069 Compare September 17, 2019 03:59
content/ember-data/v3/default-serializer.md Outdated Show resolved Hide resolved
content/ember-data/v3/default-serializer.md Outdated Show resolved Hide resolved
content/ember-data/v3/default-serializer.md Outdated Show resolved Hide resolved
content/ember-data/v3/default-serializer.md Outdated Show resolved Hide resolved
content/ember-data/v3/default-serializer.md Outdated Show resolved Hide resolved
content/ember-data/v3/default-serializer.md Outdated Show resolved Hide resolved
content/ember-data/v3/toJSON.md Outdated Show resolved Hide resolved
content/ember-data/v3/toJSON.md Outdated Show resolved Hide resolved
content/ember-data/v3/toJSON.md Outdated Show resolved Hide resolved
content/ember-data/v3/toJSON.md Outdated Show resolved Hide resolved
Copy link
Contributor

@runspired runspired left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we are almost there :D

content/ember-data/v3/default-adapter.md Outdated Show resolved Hide resolved
content/ember-data/v3/default-serializer.md Outdated Show resolved Hide resolved
content/ember-data/v3/default-serializer.md Outdated Show resolved Hide resolved
content/ember-data/v3/default-serializer.md Outdated Show resolved Hide resolved
content/ember-data/v3/default-serializer.md Outdated Show resolved Hide resolved
content/ember-data/v3/toJSON.md Outdated Show resolved Hide resolved
Copy link
Contributor

@rwjblue rwjblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good other than that one small nit...

@rwjblue rwjblue merged commit 699566a into ember-learn:master Sep 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants