[BUGFIX] backport use internalModel promise if already loading #5583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jrjohnson thanks! could you backport to |
|
No problem, new PR to release-3-2 is #5598 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes from #5562
Fixes #5579
This is super lazy, I couldn't get the new tests in that PR working. The testing model seems to have changed a bit between
releaseandmaster. There were also changes inaddon/-record-data-private/system/store.js, but I think that is new code that is only inmaster. If tests are required to merge this let me know and I will keep digging, but I thought maybe the fix was enough for a backport given the relatively small change.