[BUGFIX] use internalModel promise if already loading #5562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
runspired
changed the title
This was referenced Aug 8, 2018
runspired
force-pushed
the
fix-belongs-to-proxy
branch
from
6fa7070
to
370c01f
Compare
|
Great fix! Thanks. Is it difficult to backport this? It clears up some issues preventing us from getting to 3.2 or 3.3. I can easily wait for 3.4, but just wanted to mention it. |
This was referenced Aug 21, 2018
This was referenced Aug 22, 2018
NullVoxPopuli
pushed a commit
to NullVoxPopuli/data
that referenced
this pull request
Sep 8, 2018
* use internalModel promise if already loading * add tests * prettier to the prettier gods
runspired
added
🏷️ bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will need backported to 3.2/3.3 in addition to landing in a new 3.4 beta.
This resolves an issue that @wagenet and I debugged wherein async belongsTo relationships would not wait for
internalModelsthat are loading. The eager resolve would then leave the relationship in a state that appeared to be empty.[WIP] Working on adding a test still.