Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX beta] Fix usage of registry for 2.1.0+. #3665

Merged
merged 2 commits into from
Aug 17, 2015
Merged

[BUGFIX beta] Fix usage of registry for 2.1.0+. #3665

merged 2 commits into from
Aug 17, 2015

Commits on Aug 17, 2015

  1. [BUGFIX beta] Fix usage of registry for 2.1.0+. 

    Using `registry.resolve` is generally private API, and `container.lookupFactory`
provides roughly the same result.

We still need the registry to actually register the model we create, so
I added a small matrix inline (this was the only usage of accessing the
registry off of `this.container` that I found in the codebase).
    @rwjblue
    rwjblue committed Aug 17, 2015
    Configuration menu
    Copy the full SHA
    64ccbc3 View commit details
    Browse the repository at this point in the history

  2. Fix invalid _super call. 

    This was previously passing, because Ember 2.0.0 and lower did not
properly rethrow the error in all circumstances.
    @rwjblue
    rwjblue committed Aug 17, 2015
    Configuration menu
    Copy the full SHA
    b6498c4 View commit details
    Browse the repository at this point in the history