Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX beta] Fix usage of registry for 2.1.0+. #3665

Merged
merged 2 commits into from
Aug 17, 2015

Conversation

rwjblue
Copy link
Member

@rwjblue rwjblue commented Aug 17, 2015

Using registry.resolve is generally private API, and container.lookupFactory provides roughly the same result.

We still need the registry to actually register the model we create, so I added a small matrix inline (this was the only usage of accessing the registry off of this.container that I found in the codebase).

Using `registry.resolve` is generally private API, and `container.lookupFactory`
provides roughly the same result.

We still need the registry to actually register the model we create, so
I added a small matrix inline (this was the only usage of accessing the
registry off of `this.container` that I found in the codebase).
This was previously passing, because Ember 2.0.0 and lower did not
properly rethrow the error in all circumstances.
@rwjblue
Copy link
Member Author

rwjblue commented Aug 17, 2015

I added another commit that is unrelated to the registry usage issue here. It was required to fix the beta/canary test suite...

@bmac
Copy link
Member

bmac commented Aug 17, 2015

Thanks @rwjblue.

bmac added a commit that referenced this pull request Aug 17, 2015
[BUGFIX beta] Fix usage of registry for 2.1.0+.
@bmac bmac merged commit f973fd4 into emberjs:master Aug 17, 2015
@rwjblue rwjblue deleted the remove-private-registry-usage branch August 20, 2015 15:56
@thec0keman
Copy link

@bmac would it be possible to get this ported back into the 1.13.x branch?

@bmac
Copy link
Member

bmac commented Oct 11, 2015

@thec0keman Just so I understand would the purpose of back porting this fix to the 1.13.x branch be so it can work with Ember 2.1 or is there another issue here?

@thec0keman
Copy link

Correct, so that 1.13.x could work on Ember 2.1.

bmac added a commit that referenced this pull request Oct 16, 2015
Backport Fix usage of registry for 2.1.0+ from pr #3665
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants