Use detail instead of details for JSON API error objects
#3497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. @wecc r? |
|
👍 |
1 similar comment
|
👍 |
|
Can you please tag the commit message with [BUGFIX release] |
sebastianseilund
force-pushed
the
json-api-error-detail
branch
from
c574e30
to
b32b7a9
Compare
|
@igorT Done :) |
mixonic
added a commit
that referenced
this pull request
Jul 6, 2015
Use `detail` instead of `details` for JSON API error objects
|
Thanks @sebastianseilund :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3494.
The current implementation reads the
detailsproperty on JSON API errors.The JSON API spec mentions a field named
detail, which error objects "MAY" contain.This PR changes all instances to be
detail.