Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use detail instead of details for JSON API errors #3494

Closed
sebastianseilund opened this issue Jul 3, 2015 · 3 comments
Closed

Use detail instead of details for JSON API errors #3494

sebastianseilund opened this issue Jul 3, 2015 · 3 comments

Comments

@sebastianseilund
Copy link
Contributor

The current implementation reads the details property on JSON API errors.

The JSON API spec mentions a field named detail, which error objects "MAY" contain.

Shouldn't Ember Data use the same name (detail)? I had implemented my JSON API per the spec, and it took me a while to figure out why my error messages were blank.

I can make a PR, if you agree.
@dschmidt dschmidt mentioned this issue Jul 4, 2015
Merged
@igorT
Copy link
Member

igorT commented Jul 4, 2015

cc @tchak

@igorT
Copy link
Member

igorT commented Jul 4, 2015

Thanks for the issue, we should be following the spec, so it seems like an oversight

@sebastianseilund sebastianseilund mentioned this issue Jul 5, 2015
Merged
@sebastianseilund
Copy link
Contributor Author

Thanks. I submitted a PR. Closing this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@igorT @sebastianseilund