Deprecate store:application and store:main in favor of service:store
#3286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we add a test for the duplicate store bug, or is it too hard? |
10 tasks
bmac
changed the title
store:application and store:main in favor of service:store
|
@igorT I have updated this pr to add deprecation warnings. |
use service:store`app/services/store.js` to prevent duplicate stores.
|
👍 merge whenever travis likes it |
bmac
added a commit
that referenced
this pull request
Jun 13, 2015
Deprecate `store:application` and `store:main` in favor of `service:store`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now Ember Data supports 3 namespaces where you can define the store
store:main,store:applicationandservice:store. I want to reduce this to 1 place for Ember Data 2.0 because it simplifies our initializer code and if a user were to define a custom store for more then 1 of those namespaces it can result in multiple stores instances in their app which is confusing to debug.I'd like to recommend defining a custom store as
service:store(app/services/store.js) as the path going forward. Is this a good idea/bad idea?I would also like to see this pr become a beta-19.2 patch release to help people upgrading who currently have a custom store defined in
app/store.js. Let me know what you think about this change?