Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow injection as service #76

Closed
st-h opened this issue Sep 24, 2015 · 3 comments
Closed

Allow injection as service #76

st-h opened this issue Sep 24, 2015 · 3 comments
Assignees
@gordonkristan

Comments

@st-h
Copy link
Contributor

st-h commented Sep 24, 2015

Ember data has switched to identifying the store as 'service:store', which is pretty nice as the store can be injected where it is needed.

Can we change that convention in ember-graph as well?

the related discussion and PR for ember data can be found here:
emberjs/data#3286
@gordonkristan
Copy link
Contributor

Yeah, definitely. It's been on my list of things to do, but I wasn't in any hurry because I wasn't sure who was using this. 😄 I'll try to tackle this over the weekend. 👍

@gordonkristan gordonkristan self-assigned this Sep 24, 2015
@gordonkristan gordonkristan mentioned this issue Sep 26, 2015
Merged
@gordonkristan
Copy link
Contributor

You can now access the store both ways. 👍

@st-h
Copy link
Contributor Author

st-h commented Oct 9, 2015

Thank you. Works great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gordonkristan gordonkristan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gordonkristan @st-h