Fix syntax highlighting #2073
Merged
Fix syntax highlighting #2073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#2071 broke syntax highlighting because guides-sources fails to satisfy ember-shiki's peerDependency on showdown. By not providing it, we left pnpm free to pick whatever copy it wanted, and thus there was no way to guarantee that ember-shiki and the rest of guides-source were using *the same* copy.
✅ Deploy Preview for ember-guides ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
kategengler
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2071 broke syntax highlighting because guides-sources fails to satisfy ember-shiki's peerDependency on showdown.
By not providing it, we left pnpm free to pick whatever copy it wanted, and thus there was no way to guarantee that ember-shiki and the rest of guides-source were using the same copy.