Switch to pnpm #2071
Merged
Switch to pnpm #2071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ember-guides ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ef4
commented
Nov 6, 2024
Comment on lines
+44
to
+46
| "@ember-data/adapter": "^4.4.3", | ||
| "@ember-data/model": "^4.4.3", | ||
| "@ember-data/serializer": "^4.4.3", |
There was a problem hiding this comment.
These are peerDependencies of guidemaker that were previously being sloppily provided by ember-data's transitive dependencies. pnpm will more strictly do what you say, and by not having these we were letting guidemaker's "*" dependencies auto-install the very latest @ember-data/* packages instead, which don't work.
ef4
commented
Nov 6, 2024
- needed to add some peer deps that we were missing - needed to prevent a compatible upgrade to markdown-link-extractor because it made node-tests hundreds of times slower
|
This is ready to go. I'm pretty sure there is a pre-existing flaky test in |
kategengler
approved these changes
Nov 7, 2024
ef4
added a commit
that referenced
this pull request
Nov 8, 2024
#2071 broke syntax highlighting because guides-sources fails to satisfy ember-shiki's peerDependency on showdown. By not providing it, we left pnpm free to pick whatever copy it wanted, and thus there was no way to guarantee that ember-shiki and the rest of guides-source were using *the same* copy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ember.js, ember-cli, embroider, etc are all using pnpm now. It's the least bad NPM client, and having it here will help will upcoming updates.