Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid **/tmp/** when looking for package.json's. #140

Merged
merged 1 commit into from
Jun 23, 2019

Conversation

rwjblue
Copy link
Member

@rwjblue rwjblue commented Jun 23, 2019

Attempt to fix #138.

Part of the issues in #138 is that tmp/ is being "walked" for package.json's (on accident) so that we can properly map from the runtime module paths to the local on disk paths. Unfortunately, when walking the current directory tmp may still be around (especially when using ember-cli that is still using [email protected] where the tmp is in the project).

This PR adds tmp to the list of paths to ignore, which should help us avoid the issue described in joliss/node-walk-sync#44.

@rwjblue rwjblue added the bug Something isn't working label Jun 23, 2019
@rwjblue rwjblue merged commit 5148190 into ember-codemods:master Jun 23, 2019
@rwjblue rwjblue deleted the avoid-walking-tmp branch June 23, 2019 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Codemod errors when run as per Readme
1 participant