-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Codemod errors when run as per Readme #138
Comments
I experienced roughly the same thing trying to run it against my app. |
Update: after updating to ember and ember-cli 3.10, and eliminating broccoli warnings, it still fails, but my errors are different:
|
…ks walk-sync. This addition to the test suite illustrates the issue. (Note that there are no tests added, so this PR is really just a way to reproduce the problem.) I ran into this trying to run the ember-native-class-codemod with the error captured here: ember-codemods/ember-native-class-codemod#138
The The real issue (as @lukemelia ultimately identified) is that I suspect that we can likely avoid walking |
Can y'all test v1.0.1 (includes #140)? |
Still got a bunch of
|
@kategengler - Ya, I'm working on refactoring those warnings to be much more approachable. They are "expected", but the message is horrible. |
Succeeded for me too. "@service" decorators were doubled up, but I'll create a separate issue for that. |
Thanks @lukemelia |
I'll close this one then, and we can create/track the other poor ux issues in separate issues. |
…ks walk-sync. This addition to the test suite illustrates the issue. (Note that there are no tests added, so this PR is really just a way to reproduce the problem.) I ran into this trying to run the ember-native-class-codemod with the error captured here: ember-codemods/ember-native-class-codemod#138
I am running into something similar:
On Windows 10 :) |
With my app running on localhost:4200, and running the codemod like so:
npx ember-native-class-codemod http://localhost:4200/ app
I see the following errors:
and then the codemod outputs an error:
and then ends with:
But nothing has been modified.
The text was updated successfully, but these errors were encountered: