Set ember-source dependency to null for bower scenarios
#15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
reviewed
Nov 6, 2017
yeah, that would be one of the next steps, though I'd prefer to figure #13 out first 🤔 |
Turbo87
changed the title
ember-source dependency to null for bower scenariosember-source dependency to null for bower scenarios
Merged
hjdivad
added a commit
to ember-cli/ember-try
that referenced
this pull request
Nov 8, 2017
ember-cli/ember-try-config#15 changed behaviour in 2.2.0 to set ember-source to null.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #14
This should probably be backported to v1.x once merged so that older Ember CLI releases can take advantage of this.