Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scenario generator "broken" if ember-source is used #14

Closed
Turbo87 opened this issue Nov 6, 2017 · 1 comment
Closed

Scenario generator "broken" if ember-source is used #14

Turbo87 opened this issue Nov 6, 2017 · 1 comment
Labels

Comments

@Turbo87
Copy link
Member

Turbo87 commented Nov 6, 2017

If the addon that is being tested has a dependency on ember-source then the scenario generator will work, but the scenarios generated (using bower) will not set ember-source to null which results in the Ember version being used to always be the one from ember-source.

In other words: All addons that use useVersionCompatibility and ember-source are not actually testing against the Ember versions that ember-try claims to test against, but are instead all testing against the same version of the original ember-try dependency.

This can be tested using e.g.

assert.equal(Ember.VERSION, '2.16.2');

which will pass on all generated scenarios if the ember-source version is 2.16.2.

This was discovered in mainmatter/ember-test-selectors#150

/cc @rwjblue @kategengler

@Turbo87
Copy link
Member Author

Turbo87 commented Nov 7, 2017

released as v2.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant