Skip to content
This repository has been archived by the owner on Dec 8, 2024. It is now read-only.

Export modules with RSVP to avoid destructuring #67

Closed
wants to merge 1 commit into from
Closed

Export modules with RSVP to avoid destructuring #67

wants to merge 1 commit into from

Conversation

danmcclain
Copy link

No description provided.

@rwjblue
Copy link
Member

rwjblue commented Jun 11, 2016

I like it. I'd much prefer to import named instead of importing RSVP then destructuring. I believe this also matches RAVP's normal exports.

@danmcclain - We will need to PR against Stef's pending PR in Ember itself (we need to keep these repos in sync). Would you mind doing that also?

@stefanpenner - r?

@stefanpenner
Copy link
Contributor

stefanpenner commented Jun 11, 2016

I would prefer to wait as we decide what we want to expose. Wholesale including all the things, like cast and throw seems like a bad choice, maybe others. In addition, I am unsure about such first class promise features, such as resolve etc, which should actually by spec reside on a Promise and cannot be destructured, because they rely on this being an appropriate constructor.

@rwjblue
Copy link
Member

rwjblue commented Jun 11, 2016

@stefanpenner - Sounds good. I believe the point here was to emulate the already existing RSVP public API (taken from lib/rsvp.js).

@danmcclain
Copy link
Author

@rwjblue Confirm, I was going for 1:1 with the current rsvp.js exports

@rwjblue
Copy link
Member

rwjblue commented Jun 18, 2016

@stefanpenner - Are those that you mentioned going to be deprecated and removed by RSVP? Either way, can you list the ones to remove from this PR so that we can at least use imports for some of the things?

@Turbo87
Copy link
Member

Turbo87 commented Mar 17, 2017

closing due to inactivity

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants