Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional RSVP imports #13

Closed
Turbo87 opened this issue Jul 6, 2017 · 4 comments · Fixed by #21
Closed

Additional RSVP imports #13

Turbo87 opened this issue Jul 6, 2017 · 4 comments · Fixed by #21

Comments

@Turbo87
Copy link
Member

Turbo87 commented Jul 6, 2017

Right now it is only possible to

import RSVP from 'rsvp';

but to get to Promise or resolve() it is not possible to

import { Promise, resolve } from 'rsvp';

IMHO we should change that

@locks
Copy link
Contributor

locks commented Jul 6, 2017

Not a bad idea, indeed.

@rwjblue
Copy link
Member

rwjblue commented Jul 6, 2017

Seems like a dupe of ember-cli/ember-cli-shims#67 which @stefanpenner opposed 😕

@cibernox
Copy link
Collaborator

cibernox commented Jul 7, 2017

FWIW, I think that it makes sense to expose Promise directly, without destructuring RSVP. However, since Promise.resolve is part of the spec, I don't see the case for RSVP.resolve, unless there is some subtle difference I'm not aware of.

@rwjblue
Copy link
Member

rwjblue commented Jul 8, 2017

Some of this is done, but as I mentioned in #18 we should likely bring in a few more named exports here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants