Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: search on small screens #585

Merged
merged 1 commit into from
Dec 27, 2022
Merged

feat: search on small screens #585

merged 1 commit into from
Dec 27, 2022

Conversation

patak-dev
Copy link
Member

@patak-dev patak-dev commented Dec 27, 2022

Fixes #545
Fixes #546

Description

  • Adds Search icon on mobile, and removes explore and local (moved to ...)
  • Adds /search route
  • For md screens, once the right sidebar is collapsed, replace the explore icon in the left sidebar with search
  • Avoid "Search Elk", just use "Search" as the placeholder

This is following the UI of twitter which also seems to work quite well for Mastodon.

@LittleSound is working on embedding the search widget on the command palette here:

This PR temporarily adds the search widget from the right sidebar as is in the new /search route. @LittleSound once we merge your PR, could you also use your new widget for this route if it is a good fit?

cc @TodePond

@stackblitz
Copy link

stackblitz bot commented Dec 27, 2022

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@netlify
Copy link

netlify bot commented Dec 27, 2022

Deploy Preview for elk-zone ready!

Name Link
🔨 Latest commit a8be0c6
🔍 Latest deploy log https://app.netlify.com/sites/elk-zone/deploys/63ab650ba375470008008f6d
😎 Deploy Preview https://deploy-preview-585--elk-zone.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unexpected order of menu items on mobile No search bar in mobile
1 participant