fix: don't decode HTML entities (&foo;
) until rendering
#465
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed my status containing an unclosed (
some <text> ...
) html tag cause the status to be displayed with justsome
(live example expected / actual )Effectively the parses has a line decodes the rawsome >text<
into raw HTML which causes a new tree child, while afaik it should only decode these entities while rendering.elk/composables/content-parse.ts
Line 43 in e880cd7
This PR moves the decoding to the render step. I extensively tested different types of content including MD codeblocks and this seems to do the trick.
I attempted to set up a test but couldn't get
nr test
to work inside Codeflow due to missing pnpm.This fixes #346 and fixes #353, not sure if or how it impacts #256