Wrap join on with list #866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcapel
commented
Feb 21, 2024
| @@ -2291,6 +2291,19 @@ defmodule Explorer.DataFrameTest do | |||
| assert_raise ArgumentError, msg, fn -> DF.join(left, right, how: :inner_join) end | |||
| end | |||
|
|
|||
| test "with matching column indexes as single value" do | |||
There was a problem hiding this comment.
I pulled the simplest test from within the existing tests to create a base case covering the expected behavior. Not sure if there are any edge cases worth covering, but this clearly demonstrates a red/green on the desired case from my end.
philss
approved these changes
Feb 21, 2024
| @@ -2291,6 +2291,19 @@ defmodule Explorer.DataFrameTest do | |||
| assert_raise ArgumentError, msg, fn -> DF.join(left, right, how: :inner_join) end | |||
| end | |||
|
|
|||
| test "with matching column indexes as single value" do | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Use
List.wrap/1to wrap the:onoption tojoin/3allowing users to give a single column without raising a match error from the case withinjoin/3.Fixes #865