You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Allowing a single value as valid (as opposed to a list) in join (e.g. DF.join(df, on: :some_column) becomes valid)
Giving an argument error when a list isn't given.
I was quickly moving through the docs and didn't notice the given examples all used a list of column names. The exception that is raised here is not very intuitive:
** (CaseClauseError) no case clause matching: {:fips, :inner}
(explorer 0.8.0) lib/explorer/data_frame.ex:4931: Explorer.DataFrame.join/3
#cell:rr454i5svjo3vvcp:1: (file)
Where in this case :fips is the column I would like to use. It seems like updating the case could work. Alternatively the case could default to an error that explains the issue more clearly.
In my opinion, allowing a single column value seems like the reasonable behavior. Happy to write up a PR for either case.
The text was updated successfully, but these errors were encountered:
* add failing test for case
#865
* use List.wrap/1 with opts[:on] for join/3
* update docs to reflect changes
---------
Co-authored-by: Philip Capel <[email protected]>
I'm curious what you're thoughts are on:
join
(e.g.DF.join(df, on: :some_column)
becomes valid)I was quickly moving through the docs and didn't notice the given examples all used a list of column names. The exception that is raised here is not very intuitive:
Where in this case
:fips
is the column I would like to use. It seems like updating the case could work. Alternatively the case could default to an error that explains the issue more clearly.In my opinion, allowing a single column value seems like the reasonable behavior. Happy to write up a PR for either case.
The text was updated successfully, but these errors were encountered: