Support more integer dtypes in Series #824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is part of #794
This is to make them work with integers.
This changes a little bit the algorithm for the "out_dtype" in some arithmetic operations.
42 tasks
josevalim
reviewed
Jan 16, 2024
josevalim
reviewed
Jan 16, 2024
Co-authored-by: Billy Lanchantin <[email protected]>
josevalim
reviewed
Jan 16, 2024
The idea is to have fewer series in memory.
Overflow may occur, but it's fine.
josevalim
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first part of the work I'm doing in #794
It supports the new signed and unsigned integer dtypes in operations for the Series module (and one small change in the DF). Mostly that we have here is regarding the "eager" implementation of a Series, although some bugs from the "lazy" series were solved as well.
I'm skipping the "pow/2" function because @billylanchantin is covering that in #821 :D
UPDATE 1: and
Series.concat/2is being tackled in #812 by @lkarthee :D