-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix mismatched types in Series.pow
#821
Conversation
Co-authored-by: lkarthee <[email protected]>
Co-authored-by: lkarthee <[email protected]>
Hey sorry for the churn! I was playing with a version that kept everything in Elixir but I didn't mean to push it yet. |
Ok I think this new Elixir-only direction is better.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Smart use of DFs!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Nice usage of the DF, and nice way to test it! :D
But I want to document it before we merge. Otherwise anyone coming in with Polars expectations will be thrown off.
The idea here is to document for the end users, right? I'm 👍 for this.
Thanks, y'all!
@philss Yeah exactly. Raising on |
Co-authored-by: josevalim <[email protected]>
Note: I misunderstood what @josevalim was getting at with his suggestion above. He was only consolidating the cases, not making We can still do that if we want, but perhaps that should be a separate PR. If so, I think this one is good to go. Give this comment a 👍 if we're good with that and I'll merge it. (Or someone can just merge it themselves 😄) |
Fixes:
Explorer.Series.pow/2
result in data frame and series when mutate with lazy series #374New dtype handling as of Rust Polars 0.36.2: