Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use same s3 bucket with deployment env path #1153

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

de-code
Copy link
Collaborator

@de-code de-code commented Dec 19, 2022

see also #1152

this allows to use a deployment env like de_dev without requiring a separate bucket

(only include done sample config, it could be applied to all of them)

this allows to use a deployment env like `de_dev` without requiring a separate bucket
@de-code de-code requested a review from HazalCiplak December 19, 2022 08:24
@de-code de-code self-assigned this Dec 19, 2022
@de-code
Copy link
Collaborator Author

de-code commented Dec 19, 2022

I suggest to maybe before merging:

  • ask Scott to create a new S3 bucket, e.g. elife-data-pipeline
  • update config to use the new bucket
  • update all of the sample config

(Then we would avoid mixed content in the bucket)

@HazalCiplak
Copy link
Member

I think, it will be good to have a prefix on the bucket name, like dev-elife-data-pipeline or test-elife-data-pipeline. What do you think?

@de-code
Copy link
Collaborator Author

de-code commented Dec 20, 2022

I think, it will be good to have a prefix on the bucket name, like dev-elife-data-pipeline or test-elife-data-pipeline. What do you think?

I actually thought we could then also move prod and staging over in the future too. (Then we could delete the other three buckets)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants