Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make deployment env configurable #1152

Merged
merged 1 commit into from
Dec 19, 2022
Merged

make deployment env configurable #1152

merged 1 commit into from
Dec 19, 2022

Conversation

de-code
Copy link
Collaborator

@de-code de-code commented Dec 19, 2022

this would make the deployment env configurable, e.g. by setting (environment variable):
DATA_HUB_DEPLOYMENT_ENV=de_dev

Although there will be issues where we assume that a S3 bucket with the deployment env exists.

@de-code de-code requested a review from HazalCiplak December 19, 2022 08:19
@de-code de-code self-assigned this Dec 19, 2022
@de-code de-code mentioned this pull request Dec 19, 2022
Draft
@de-code de-code marked this pull request as ready for review December 19, 2022 12:32
@de-code de-code merged commit 98d9c75 into develop Dec 19, 2022
@de-code de-code deleted the configurable-data-hub-env branch December 19, 2022 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HazalCiplak HazalCiplak HazalCiplak approved these changes

Assignees

@de-code de-code

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@de-code @HazalCiplak