Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new development assets and use in mocks/previews. #3581

Merged
merged 2 commits into from
Dec 3, 2024

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Dec 3, 2024

Follow on from #3569, this PR adds some specific assets for images, videos and avatars so that we're not building against the logo which is a circle with alpha.

Lots of snapshots, I tweaked a few so they render the full height rather than being clipped.

@pixlwave pixlwave requested a review from a team as a code owner December 3, 2024 16:14
@pixlwave pixlwave requested review from stefanceriu and removed request for a team December 3, 2024 16:14
Copy link

github-actions bot commented Dec 3, 2024

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 57a1365

Copy link
Member

@Velin92 Velin92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, no we have some diversity in testing images in previews

@pixlwave pixlwave added the pr-build for changes related to build, tools, CI/CD label Dec 3, 2024
Copy link

sonarqubecloud bot commented Dec 3, 2024

@pixlwave pixlwave merged commit 4966083 into develop Dec 3, 2024
8 checks passed
@pixlwave pixlwave deleted the doug/mock-images branch December 3, 2024 17:14
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.84%. Comparing base (7e5624f) to head (57a1365).
Report is 2 commits behind head on develop.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3581      +/-   ##
===========================================
+ Coverage    78.82%   78.84%   +0.01%     
===========================================
  Files          757      757              
  Lines        63843    63798      -45     
===========================================
- Hits         50325    50302      -23     
+ Misses       13518    13496      -22     
Flag Coverage Δ
unittests 69.89% <100.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pixlwave pixlwave mentioned this pull request Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-build for changes related to build, tools, CI/CD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants