Make the Unit Test media files into development assets. #3569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move UnitTests/Resources/Media into a top-level DevelopmentAssets directory.
Generated by 🚫 Danger Swift against 76fe1bd |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3569 +/- ##
===========================================
- Coverage 78.58% 78.55% -0.04%
===========================================
Files 757 757
Lines 63662 63662
===========================================
- Hits 50031 50009 -22
- Misses 13631 13653 +22
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Velin92
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the following changes:
UnitTests/Resources/Mediainto a top-levelDevelopmentAssetsdirectory.DevelopmentAssets/Mediaas resources to the Element X target, also flagging them as development assets.This will mean that we can reference these assets in SwiftUI previews, and Xcode will strip them from the release bundle when uploading to the App Store.