Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the strings for unsupported calls. #3502

Merged
merged 1 commit into from
Nov 11, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -226,6 +226,7 @@
"common_unable_to_invite_title" = "Unable to send invite(s)";
"common_unlock" = "Unlock";
"common_unmute" = "Unmute";
"common_unsupported_call" = "Unsupported call";
"common_unsupported_event" = "Unsupported event";
"common_username" = "Username";
"common_verification_cancelled" = "Verification cancelled";
Expand Down Expand Up @@ -789,6 +790,7 @@
"screen_room_timeline_add_reaction" = "Add emoji";
"screen_room_timeline_beginning_of_room" = "This is the beginning of %1$@.";
"screen_room_timeline_beginning_of_room_no_name" = "This is the beginning of this conversation.";
"screen_room_timeline_legacy_call" = "Unsupported call. Ask if the caller can use to the new Element X app.";
"screen_room_timeline_less_reactions" = "Show less";
"screen_room_timeline_message_copied" = "Message copied";
"screen_room_timeline_no_permission_to_post" = "You do not have permission to post to this room";
Expand Down
4 changes: 4 additions & 0 deletions ElementX/Sources/Generated/Strings.swift
Original file line number Diff line number Diff line change
Expand Up @@ -512,6 +512,8 @@ internal enum L10n {
internal static var commonUnlock: String { return L10n.tr("Localizable", "common_unlock") }
/// Unmute
internal static var commonUnmute: String { return L10n.tr("Localizable", "common_unmute") }
/// Unsupported call
internal static var commonUnsupportedCall: String { return L10n.tr("Localizable", "common_unsupported_call") }
/// Unsupported event
internal static var commonUnsupportedEvent: String { return L10n.tr("Localizable", "common_unsupported_event") }
/// Username
Expand Down Expand Up @@ -1926,6 +1928,8 @@ internal enum L10n {
}
/// This is the beginning of this conversation.
internal static var screenRoomTimelineBeginningOfRoomNoName: String { return L10n.tr("Localizable", "screen_room_timeline_beginning_of_room_no_name") }
/// Unsupported call. Ask if the caller can use to the new Element X app.
internal static var screenRoomTimelineLegacyCall: String { return L10n.tr("Localizable", "screen_room_timeline_legacy_call") }
/// Show less
internal static var screenRoomTimelineLessReactions: String { return L10n.tr("Localizable", "screen_room_timeline_less_reactions") }
/// Message copied
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,12 +13,15 @@ struct CallInviteRoomTimelineView: View {
let timelineItem: CallInviteRoomTimelineItem

var body: some View {
Label(title: { Text(L10n.commonCallInvite) },
icon: { CompoundIcon(\.voiceCall, size: .medium, relativeTo: .compound.bodyMD) })
.font(.compound.bodyMD)
.foregroundColor(.compound.textSecondary)
.frame(maxWidth: .infinity, alignment: .center)
.padding()
Label {
Text(L10n.screenRoomTimelineLegacyCall)
} icon: {
CompoundIcon(\.voiceCall, size: .medium, relativeTo: .compound.bodyMD)
}
.font(.compound.bodyMD)
.foregroundColor(.compound.textSecondary)
.frame(maxWidth: .infinity, alignment: .center)
.padding()
}
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ struct RoomEventStringBuilder {
}
return prefix(L10n.commonPollSummary(question), with: displayName)
case .callInvite:
return prefix(L10n.commonCallInvite, with: displayName)
return prefix(L10n.commonUnsupportedCall, with: displayName)
case .callNotify:
return prefix(L10n.commonCallStarted, with: displayName)
}
Expand Down
2 changes: 1 addition & 1 deletion NSE/Sources/NotificationContentBuilder.swift
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ struct NotificationContentBuilder {

private func processCallInviteEvent(notificationItem: NotificationItemProxyProtocol, mediaProvider: MediaProviderProtocol?) async throws -> UNMutableNotificationContent {
let notification = try await processCommonRoomMessage(notificationItem: notificationItem, mediaProvider: mediaProvider)
notification.body = L10n.commonCallInvite
notification.body = L10n.commonUnsupportedCall
return notification
}

Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading