Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the strings for unsupported calls. #3502

Merged
merged 1 commit into from
Nov 11, 2024
Merged

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave added the pr-misc for other changes label Nov 11, 2024
@pixlwave pixlwave requested a review from a team as a code owner November 11, 2024 12:45
@pixlwave pixlwave requested review from Velin92 and removed request for a team November 11, 2024 12:45
Copy link

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 993523c

1 similar comment
Copy link

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 993523c

Copy link

Copy link

codecov bot commented Nov 11, 2024

Codecov Report

Attention: Patch coverage is 81.81818% with 2 lines in your changes missing coverage. Please review.

Project coverage is 78.75%. Comparing base (096bdbb) to head (993523c).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
...ices/Room/RoomSummary/RoomEventStringBuilder.swift 0.00% 1 Missing ⚠️
NSE/Sources/NotificationContentBuilder.swift 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3502   +/-   ##
========================================
  Coverage    78.75%   78.75%           
========================================
  Files          743      743           
  Lines        61902    61905    +3     
========================================
+ Hits         48748    48756    +8     
+ Misses       13154    13149    -5     
Flag Coverage Δ
unittests 69.49% <81.81%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pixlwave pixlwave merged commit 77ade52 into develop Nov 11, 2024
13 checks passed
@pixlwave pixlwave deleted the doug/legacy-call-strings branch November 11, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-misc for other changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants