Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix format bar position #28591

Merged
merged 1 commit into from
Nov 29, 2024
Merged

Conversation

florianduros
Copy link
Member

@florianduros florianduros commented Nov 28, 2024

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • I have licensed the changes to Element by completing the Contributor License Agreement (CLA)

Closes #28532

  • When we want to display the format bar, the component doesn't have yet its height. Since the height is hardcoded in CSS, we can use also an hardcoded value for the computation.
  • Added 1 px more than the initial computation which didn't include the border size, it allows the selection to not overflow over the formatting bar.

Copy link
Member

@dbkr dbkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@florianduros florianduros added this pull request to the merge queue Nov 29, 2024
Merged via the queue into develop with commit 2b4ce62 Nov 29, 2024
53 checks passed
@florianduros florianduros deleted the florianduros/fix-format-bar-position branch November 29, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Text formatting palette hides text if you select it.
2 participants