Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove manual device verification which is not supported by the new cryptography stack #28588

Merged
merged 7 commits into from
Dec 3, 2024
Merged

Remove manual device verification which is not supported by the new cryptography stack #28588

merged 7 commits into from
Dec 3, 2024
+237 −527

Conversation

florianduros
Copy link
Member

@florianduros florianduros commented Nov 28, 2024 •
edited
Loading

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • I have licensed the changes to Element by completing the Contributor License Agreement (CLA)

Task #26922
Closes #27201

  • Replace usage of deprecated crypto events
  • Remove call of MatrixClient.setDeviceVerified

@florianduros florianduros added the T-Task Tasks for the team like planning label Nov 28, 2024
@florianduros florianduros force-pushed the florianduros/rip-out-legacy-crypto/fix-usage-deprecated branch from d4b922f to 9d452d5 Compare November 28, 2024 11:35
@florianduros florianduros force-pushed the florianduros/rip-out-legacy-crypto/fix-usage-deprecated branch from 9d452d5 to 1b35526 Compare November 28, 2024 12:55
@florianduros florianduros changed the title Remove deprecated usages of *js-sdk* Remove deprecated usages of js-sdk Nov 28, 2024
@florianduros florianduros marked this pull request as ready for review November 28, 2024 13:35
@florianduros florianduros requested a review from a team as a code owner November 28, 2024 13:35
@florianduros florianduros requested a review from a team as a code owner November 28, 2024 14:16
@florianduros florianduros requested a review from richvdh November 28, 2024 14:16
richvdh
richvdh reviewed Nov 29, 2024
View reviewed changes
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm otherwise

src/verification.ts Show resolved Hide resolved
@florianduros florianduros added T-Defect and removed T-Task Tasks for the team like planning labels Nov 29, 2024
@florianduros florianduros changed the title Remove deprecated usages of js-sdk Remove manual device verification which is not supported by the new cryptography stack Nov 29, 2024
@florianduros florianduros requested a review from richvdh November 29, 2024 13:34
@florianduros florianduros mentioned this pull request Dec 2, 2024
Open
@richvdh
Copy link
Member

richvdh commented Dec 2, 2024

I think this fixes #27201 ?

richvdh
richvdh requested changes Dec 2, 2024
View reviewed changes
src/components/views/dialogs/UntrustedDeviceDialog.tsx Show resolved Hide resolved
src/verification.ts Outdated Show resolved Hide resolved
@florianduros florianduros requested a review from richvdh December 3, 2024 14:33
richvdh
richvdh approved these changes Dec 3, 2024
View reviewed changes
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise

src/components/views/dialogs/UntrustedDeviceDialog.tsx Outdated Show resolved Hide resolved
@florianduros florianduros added this pull request to the merge queue Dec 3, 2024
github-merge-queue bot pushed a commit that referenced this pull request Dec 3, 2024
@florianduros
Remove manual device verification which is not supported by the new c…
6ca4276 
…ryptography stack (#28588)

* Remove call of `MatrixClient.setDeviceVerified`

* Replace usage of deprecated crypto events

* Replace deprecated imports

* Remove legacy button in `UntrustedDeviceDialog`

* Review fixes

* Add tests

* Fix doc
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 3, 2024
@florianduros florianduros added this pull request to the merge queue Dec 3, 2024
Merged via the queue into develop with commit d2acce1 Dec 3, 2024
33 checks passed
@florianduros florianduros deleted the florianduros/rip-out-legacy-crypto/fix-usage-deprecated branch December 3, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richvdh richvdh richvdh approved these changes

@dbkr dbkr dbkr approved these changes

@MidhunSureshR MidhunSureshR Awaiting requested review from MidhunSureshR MidhunSureshR is a code owner automatically assigned from element-hq/element-web-reviewers

Assignees
No one assigned
Labels
T-Defect
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Manual Device Verification (eyeballing the key) doesn't work in ER
3 participants
@florianduros @richvdh @dbkr