-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document feature_notifications_panel labs flag #25924
Conversation
docs/labs.md
Outdated
|
||
## Notifications panels (`feature_notifications_panel`) | ||
|
||
A list of all events notifying the current user. Only works with unencrypted content. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only works with unencrypted content.
This isn't true, it depends on a user's push rules. If a user marked their .m.room.encrypted*
push rules with highlight=true then it'd include those too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But in reality, does that ever happen? I'd be more inclined to add smething a bit simpler
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its also not right because we don't only show notifications
- we show only highlighting notifications. You will have more notifications than you will find in this panel even for unencrypted rooms. notify != highlight
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In reality if we wish to maintain the highlight behaviour this panel should probably be renamed to Mentions
@daniellekirkwood could you help us resolve the wording discussion above? I'm not convinced we should rebrand this piece of UI at this stage, nor should we go with a too technical description. It might be a good idea to revamp it the day we put some more attention and care to it. |
Labs flags in product appear to have the structure: Header, subhead so my suggestion would be this:
|
For https://github.com/vector-im/element-internal/issues/444
Checklist
This change is marked as an internal change (Task), so will not be included in the changelog.