Move notification bell to space panel #11373
Conversation
germain-gg
added
the
T-Task
| controller: new ReloadOnChangeController(), | ||
| betaInfo: { | ||
| title: _td("Notifications panel"), | ||
| caption: () => <p>{_t("A list of all events notifying you. Only works with unencrypted rooms")}</p>, |
There was a problem hiding this comment.
Only works with unencrypted rooms
This isn't true
There was a problem hiding this comment.
I don't think it's desirable to be overly specific here. I'd be open to hearing alternative wording though.
This is how everyone internally at Element has described to me how this feature works. I'm trying to avoid being technically overly accurate to not overwhelm a more average user that might not grasp all the tiny distinctions between the concepts discussed here
There was a problem hiding this comment.
Looping @daniellekirkwood and @nadonomy here
There was a problem hiding this comment.
Yeah, my understanding is that it only works with Unencrypted rooms so this feels accurate.
There was a problem hiding this comment.
The /notifications API in the spec does not discriminate whether a room is encrypted or not. The actual matching is for events which match set_tweak highlight in your push rules. So if you disable Noisy notifications it won't even include unencrypted rooms.
| default: false, | ||
| // Reload to ensure that the left panel etc. get remounted | ||
| controller: new ReloadOnChangeController(), | ||
| betaInfo: { |
There was a problem hiding this comment.
Marking this as a beta implies its nearly ready for prime time, by taking this feature out of mainline stability we're saying it isn't. This will be confusing IMO
There was a problem hiding this comment.
This is the only way to make it available to people who do not use develop/nightly.
I don't think this will be more confusing than the way it works today
|
CI is also very unhappy |
Screen.Recording.2023-08-04.at.16.08.48.movAlso does not seem to work :/ |
germain-gg
added
T-Enhancement
|
@nadonomy should we default the labs flag to on so it's not so much of a who-moved-my-cheese all at once? @germain-gg I imagine we'll need an in-product announcement as well as a coordination in rooms and release notes. Would like Nad's thoughts on that... |
For https://github.com/vector-im/internal-planning/issues/444
Moves the notification button in the space panel and adds it to labs as it currently only works with unencrypted content. We would consider getting it out of labs when it works meeting the basic expectations of our userbase, i.e. works with all events.
@nadonomy we need to coordinate on the announcement about this being labsed
@daniellekirkwood could you review the copy of the
betaInfo(in `Settings.tsx) please?Checklist
Here's what your changelog entry will look like:
✨ Features