Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Element-R: restoring individual keys from backup doesn't work #26259

Closed
Tracked by #24828
richvdh opened this issue Sep 28, 2023 · 2 comments · Fixed by matrix-org/matrix-js-sdk#3770
Closed
Tracked by #24828

Element-R: restoring individual keys from backup doesn't work #26259

richvdh opened this issue Sep 28, 2023 · 2 comments · Fixed by matrix-org/matrix-js-sdk#3770
Labels
A-Element-R Issues affecting the port of Element's crypto layer to Rust O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Tolerable Low/no impact on users T-Defect

Comments

@richvdh
Copy link
Member

richvdh commented Sep 28, 2023 •
edited
Loading

we make requests to the _matrix/client/v3/room_keys/keys/{roomId}/{sessionId} endpoint with no version.
@richvdh richvdh added T-Defect S-Tolerable Low/no impact on users O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience A-Element-R Issues affecting the port of Element's crypto layer to Rust labels Sep 28, 2023
@richvdh
Copy link
Member Author

richvdh commented Oct 2, 2023 •
edited
Loading

This also(?) seems to happen when backup is set up

@richvdh
Copy link
Member Author

richvdh commented Oct 2, 2023

I think this is happening due to a TODO in storeSessionBackupPrivateKey: https://github.com/matrix-org/matrix-js-sdk/blob/v28.2.0/src/rust-crypto/rust-crypto.ts#L999-L1000, which means we are saving a version of "" in indexeddb.

@richvdh richvdh changed the title Element-R: invalid requests to _matrix/client/v3/room_keys/keys/{roomId}/{sessionId} endpoint with no version Element-R: restoring individual keys from backup doesn't work Oct 2, 2023
@richvdh richvdh mentioned this issue Oct 2, 2023
Closed
19 tasks
@BillCarsonFr BillCarsonFr mentioned this issue Oct 3, 2023
Merged
3 tasks
@richvdh richvdh mentioned this issue Oct 3, 2023
Merged
richvdh pushed a commit to matrix-org/matrix-js-sdk that referenced this issue Oct 4, 2023
@BillCarsonFr
Rust crypto: ensure we persist the key backup version (#3770)
95baccf 
Fixes element-hq/element-web#26259
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Element-R Issues affecting the port of Element's crypto layer to Rust O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Tolerable Low/no impact on users T-Defect
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rust crypto: ensure we persist the key backup version matrix-org/matrix-js-sdk
1 participant
@richvdh