Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable rust cryptography on develop.element.io #26291

Merged
merged 3 commits into from
Oct 24, 2023
Merged

Enable rust cryptography on develop.element.io #26291

merged 3 commits into from
Oct 24, 2023

Conversation

richvdh
Copy link
Member

@richvdh richvdh commented Oct 3, 2023 •
edited by github-actions bot
Loading

Once this lands, existing sessions will continue to use legacy crypto, but new logins will use rust crypto.

This change is marked as an internal change (Task), so will not be included in the changelog.

@richvdh
Enable rust cryptography on develop.element.io
a471968 
Once this lands, *existing* sessions will continue to use legacy crypto, but
*new* logins will use rust crypto.
@richvdh richvdh requested a review from a team as a code owner October 3, 2023 14:48
@richvdh richvdh added the T-Task Tasks for the team like planning label Oct 3, 2023
@richvdh richvdh mentioned this pull request Oct 3, 2023
Closed
43 tasks
@richvdh
Copy link
Member Author

richvdh commented Oct 3, 2023

We'll follow up with a similar change for Element Desktop Nightly, but it's slightly trickier to get urgent fixes into users' hands for nightly, so will give it a few days to settle.

andybalaam
andybalaam approved these changes Oct 4, 2023
View reviewed changes
Copy link
Member

@andybalaam andybalaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All fingers crossed.

@richvdh
Copy link
Member Author

richvdh commented Oct 4, 2023

A couple more things have come up which we want to investigate first:

@richvdh
Copy link
Member Author

richvdh commented Oct 5, 2023

Even more blockers have been identified. Now tracking these with a label: https://github.com/vector-im/element-web/issues?q=is%3Aissue+is%3Aopen+label%3AZ-Element-R-Blocker

@richvdh richvdh marked this pull request as draft October 10, 2023 09:12
@BillCarsonFr BillCarsonFr mentioned this pull request Oct 10, 2023
Merged
3 tasks
@richvdh richvdh marked this pull request as ready for review October 24, 2023 13:14
@richvdh richvdh enabled auto-merge (squash) October 24, 2023 13:14
@richvdh richvdh merged commit 06e0345 into develop Oct 24, 2023
18 checks passed
@richvdh richvdh deleted the rav/element_r_on_develop branch October 24, 2023 13:34
@richvdh richvdh mentioned this pull request Oct 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andybalaam andybalaam andybalaam approved these changes

@kerryarchibald kerryarchibald Awaiting requested review from kerryarchibald kerryarchibald is a code owner automatically assigned from element-hq/element-web-reviewers

Assignees
No one assigned
Labels
T-Task Tasks for the team like planning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@richvdh @andybalaam