Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emoji translation #11013

Open
MightyCreak opened this issue Oct 1, 2019 · 16 comments
Open

Emoji translation #11013

MightyCreak opened this issue Oct 1, 2019 · 16 comments
Labels
A-Emoji I18n O-Occasional Affects or can be seen by some users regularly or most users rarely T-Enhancement X-Needs-Product More input needed from the Product team

Comments

@MightyCreak
Copy link

Is your suggestion related to a problem? Please describe.
As a non native English user, I don't know all the English translation of each emojis. Sometime the French words (my mother tong) are easier to remember.

Describe the solution you'd like
On Slack, if it is set up in something else than English, when you enter emojis by text (i.e. starting with :), you can either use the English word or its translation (e.g. :smile: or its French translation :sourire:).

Describe alternatives you've considered
Only have the translation is not good either, I like the fact that you can use both English words and the ones from your language settings.

Additional context
Screenshots from Slack:
image

image

@ghost
Copy link

ghost commented Aug 11, 2020

Can't we at least translate the name of emojis? For example: Smile, instead of : smile :
That solution is applied to the verification request by emoji.

@strixaluco
Copy link
Contributor

Emoji titles for verification are already translatable. You can contribute to your language translation here: https://translate.riot.im/

@ghost
Copy link

ghost commented Aug 11, 2020

I was not clear enough, sorry. I meant to say that a subset of Emoji titles (for verification) are already translatable. Is it possible to expand that solution to solve partially the issue here?
: smile : would remain untranslated as : smile :
However, the title Smile would be translatable.
image

@strixaluco
Copy link
Contributor

strixaluco commented Aug 11, 2020

As far as I understand, all the titles/annotations translations of emojibase, which is used in Element, are supposed to be fetched from Unicode CLDR project according to main developer. I might be missing something about terminology here because title translations don't appear in Element and I thought to look into it, but developer stated that it's an upstream's issue. Sorry if I confuse the readers.
Edit: I've asked emojibase' main developer if my understanding is correct, just to clear everything out.

@strixaluco
Copy link
Contributor

Okay, so the problem does seem to be on Element side apparently. According to emojibase docs, each locale is stored in separate dataset, while matrix-react-sdk imports only English locale:
https://github.com/matrix-org/matrix-react-sdk/blob/be2d0c9de7edb498880147c327dc5035c9a7a62f/src/emoji.ts#L17

@strixaluco
Copy link
Contributor

@MightyCreak meanwhile rework of emojibase shortcodes to enable localization has begun: milesj/emojibase#64

@MightyCreak
Copy link
Author

Just wanted to emphasize that Slack allows two translations at the same time: yours and English.

I think it is very useful since (as French is my mother tong), I often use French or English for the emoji completion. It depends on the context -- am I in a French or English room? but also on habits -- I am used to look for "thumbsup" all the time for instance.

@strixaluco
Copy link
Contributor

There is a similar issue open: element-hq/element-meta#283

@MayeulC
Copy link

MayeulC commented Aug 15, 2020

@MightyCreak meanwhile rework of emojibase shortcodes to enable localization has begun: milesj/emojibase#64

I just want to point out that this is now merged :)

@jryans jryans added I18n and removed A-I18n labels Mar 5, 2021
@SimonBrandner SimonBrandner added the O-Occasional Affects or can be seen by some users regularly or most users rarely label Feb 6, 2022
@robintown
Copy link
Member

https://emojibase.dev/docs/shortcodes#localization

To do this we'd have to switch back from IamCal shortcodes to the default Emojibase shortcodes, which might not be as much of an issue anymore, since in the past couple of years, Emojibase has updated their defaults to better match other platforms. It's a tradeoff.

@SimonBrandner
Copy link
Contributor

To do this we'd have to switch back from IamCal shortcodes to the default Emojibase shortcodes, which might not be as much of an issue anymore, since in the past couple of years, Emojibase has updated their defaults to better match other platforms. It's a tradeoff.

We only switched to IamCal (Slack) quite recently...

@yajo
Copy link

yajo commented Feb 7, 2022

If you could enable more than one style, it would be most accessible. It'd mean more paths to find the emoji, which is the goal after all.

FTR English is not my mother language, but I'm used to github and I like to search emojis like I do here because of muscle memory. When I go to some Spanish-only app (my lang), I find it more difficult to find the emojis if I cannot search for them in English. But the other way around is even more understandable and common. If it's possible to search for them in both English and Spanish, or in more than one of the modes quoted in #11013 (comment), IMHO it would be the best.

@robintown
Copy link
Member

@SimonBrandner Yes, but I'm saying that the issues solved by switching to IamCal could've maybe been solved just by updating Emojibase too, since we were using an outdated version at the time.

@SimonBrandner
Copy link
Contributor

SimonBrandner commented Feb 7, 2022

@SimonBrandner Yes, but I'm saying that the issues solved by switching to IamCal could've maybe been solved just by updating Emojibase too, since we were using an outdated version at the time.

Ah, sorry, makes sense now, I've got matrix-org/matrix-react-sdk#7286. I guess let's see after that is merged (blocked on new https://github.com/twitter/twemoji release)?

@tmarplatt
Copy link

So if I were to provide a suggestion or directly contribute emoji titles or shortcodes for my own language, where would I have to drop it?

@t3chguy
Copy link
Member

t3chguy commented Mar 30, 2022

@tmarplatt https://github.com/milesj/emojibase once we start applying i18n to emoji

@kittykat kittykat added Help Wanted Extra attention is needed X-Needs-Product More input needed from the Product team and removed Help Wanted Extra attention is needed labels May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Emoji I18n O-Occasional Affects or can be seen by some users regularly or most users rarely T-Enhancement X-Needs-Product More input needed from the Product team
Projects
None yet
Development

No branches or pull requests