[Device Manager] Render current session (PSG-671) #6903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onurays
requested review from
a team and
ouchadam
and removed request for
a team
ouchadam
reviewed
Aug 22, 2022
| is DevicesViewEvents.Loading -> showLoading(it.message) | ||
| is DevicesViewEvents.Failure -> showFailure(it.throwable) | ||
| is DevicesViewEvents.RequestReAuth -> Unit // TODO. Next PR | ||
| is DevicesViewEvents.PromptRenameDevice -> Unit // TODO. Next PR |
There was a problem hiding this comment.
if possible it could be handy to link to tickets, although I guess the PS tickets are in jira 🤔
There was a problem hiding this comment.
Yes, they are private atm.
ouchadam
reviewed
Aug 22, 2022
| } | ||
|
|
||
| override fun invalidate() = withState(viewModel) { state -> | ||
| val currentDeviceInfo = state.devices() |
There was a problem hiding this comment.
what's the difference between state.devices() and state.devices? is it possible to have a currentDeviceInfo and not have devices in the Success state?
ouchadam
approved these changes
Aug 22, 2022
* develop: (169 commits) new app layouts invites (#6911) bottom navigation tabs are removed for AppLayout (#6905) focus input when changing server address Fix copyright Improve createRoomThreePidEvents for clarity Remove roomCreatorUserId and use current userId by default Remove useless explicit field type Change visibility of LocalRoomThirdPartyInviteContent to internal Remove useless apply in CreateLocalRoomStateEventsTask Update doc Extract condition to reduce code complexity Verify tombstone event Remove safe call Add unit tests for CreateRoomFromLocalRoomTask Add unit tests for CreateLocalRoomStateEventsTask Set stateKey as empty by default Create local room state events in dedicated task Fix local events generation following the specification Update CreateRoomParams from the potential FeaturePreset before persisting Persists CreateRoomParams into LocalRoomSummaryEntity ... # Conflicts: # vector/src/main/java/im/vector/app/features/settings/devices/v2/VectorSettingsDevicesFragment.kt
|
SonarCloud Quality Gate failed. |
onurays
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Content
Implement current session section as in the new layout.
Motivation and context
#6902
Screenshots / GIFs
Tests
Tested devices
Checklist