Run exodus privacy scanner on all PRs #6308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
https://github.com/vector-im/element-android/runs/6884538793?check_suite_focus=true#step:5:233 - zero trackers in the release build. |
bmarty
approved these changes
Jun 14, 2022
.github/workflows/build.yml
Outdated
| if: github.ref == 'refs/heads/main' | ||
| # Only runs on main, no concurrency. | ||
| concurrency: | ||
| group: ${{ github.ref == 'refs/head/main' && format('integration-tests-main-{0}', github.sha) || github.ref == 'refs/heads/develop' && format('integration-tests-develop-{0}', github.sha) || format('build-debug-{0}', github.ref) }} |
There was a problem hiding this comment.
Weird to see integration-tests here, are you sure?
There was a problem hiding this comment.
Was just pulling it from the other (debug) build - i need to make sure this runs on only the right things before we merge; yes
There was a problem hiding this comment.
Have changed this to be named more appropriate too.
Build the release APK for each PR commit, run exodus against that APK.
michaelkaye
force-pushed
the
michaelk/exodus
branch
from
7a11055 to
063f082
Compare
michaelkaye
changed the title
|
(Rebase is just to clean up commit history due to lots of tweaks) |
|
Kudos, SonarCloud Quality Gate passed!
|
bmarty
added a commit
to matrix-org/pipelines
that referenced
this pull request
Jun 15, 2022
This was referenced Jun 15, 2022
richvdh
pushed a commit
to matrix-org/pipelines
that referenced
this pull request
Jun 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Content
Motivation and context
Screenshots / GIFs
Tests
Tested devices
Checklist