Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move exodus to GitHub action, and analyse release version instead of debug version #6306

Open
bmarty opened this issue Jun 14, 2022 · 1 comment
Labels
A-DevX Anything that can improve the DevX Privacy T-Task Refactoring, enabling or disabling functionality, other engineering tasks z-CI

Comments

@bmarty
Copy link
Member

bmarty commented Jun 14, 2022

Currently exodus check is performed by buildkite: https://github.com/matrix-org/pipelines/blob/master/element-android/pipeline.yml#L62 on release and debug version of the app.

This as to be done by GitHub Action now, and could later be removed from Buildkite pipeline. As a reminder, we keep Buildkite as a CI Backup for now, and it's still used to build the unsigned Gplay released version of the app.

Other things to change when implementing this issue:

  • exodus should be run only on the Release build. On Debug build we can have other trackers, and this is fine (I think). This is blocking Setup Flipper #6300, see Setup Flipper #6300 (comment) .
  • it means that GitHub action should build Release version of the app on every PR. Currently this is not the case, and this is a problem, since Debug builds can succeed and Release builds may fail. Some code/dependencies are different for both types.
  • Bonus: it will fix this TODO
@bmarty bmarty added Privacy T-Task Refactoring, enabling or disabling functionality, other engineering tasks z-CI A-DevX Anything that can improve the DevX labels Jun 14, 2022
@michaelkaye
Copy link
Contributor

#6308 is a first attempt at this.

@michaelkaye michaelkaye self-assigned this Jun 14, 2022
@michaelkaye michaelkaye removed their assignment Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-DevX Anything that can improve the DevX Privacy T-Task Refactoring, enabling or disabling functionality, other engineering tasks z-CI
Projects
None yet
Development

No branches or pull requests

2 participants