Fix EventInsertLiveObserver gets blocked by reverting and adding lock… #6279
Conversation
ganfra
requested review from
bmarty,
a team and
onurays
and removed request for
a team
| observerScope.launch { | ||
| lock.withLock { | ||
| if (!results.isLoaded || results.isEmpty()) { | ||
| return@launch |
There was a problem hiding this comment.
Probably equivalent, but is it safer to use return@withLock instead of return@launch?
There was a problem hiding this comment.
Honestly I don't know, but I can change if you prefer
bmarty
added
the
Z-NextRelease
| if (!results.isLoaded || results.isEmpty()) { | ||
| return | ||
| } | ||
| observerScope.launch { onResultsChangedFlow.emit(results) } |
There was a problem hiding this comment.
do we know the cause of the issue/reproduction steps?
There was a problem hiding this comment.
I reproduce a lot. Just sent some reactions, if you go back on room list and open again the timeline, there is a high chance you don't see the reactions as the event is not aggregated.
For the exact cause I don't know, but looks like the inner channel gets blocked by the the looper thread...
There was a problem hiding this comment.
very strange 🤔
I haven't been able to reproduce on my side, the flow always seems to emit
| GIF |
|---|
 |
|
for context, the PR that introduced the change #5909 |
|
Kudos, SonarCloud Quality Gate passed! |
|
Commits are included in 1.4.20 |
Fix #6278
Introduce a Lock instead of relying on Flow.