Fixes crash when accepting VOIP calls

[ouchadam]

Type of change

• Feature
• Bugfix
• Technical
• Other :

Content

Fixes a crash when receiving and consuming call events #5421 (tentatively fixes #5591 and possibly other VOIP quirks)

• The event insertion logic is designed to be single threaded however due to coroutine continuation, there's unintended multiple thread access when the processing and post processing overlap
• Fixed by converting the launching to a flow which will sequentially process the launch logic on the single threaded scope

Motivation and context

To fix a VOIP crash

Screenshots / GIFs

• Adds a small delay to the postProcessing step
• Send 5 messages

Before

• Notice multiple concurrent launches

Launch: LIVE_ENTITY_BACKGROUND
Process start: pool-7-thread-1
Process end: LIVE_ENTITY_BACKGROUND
Post start: LIVE_ENTITY_BACKGROUND

Launch: LIVE_ENTITY_BACKGROUND
Process start: pool-7-thread-1
Process end: LIVE_ENTITY_BACKGROUND
Post start: LIVE_ENTITY_BACKGROUND

Launch: LIVE_ENTITY_BACKGROUND
Process start: pool-7-thread-1
Process end: LIVE_ENTITY_BACKGROUND
Post start: LIVE_ENTITY_BACKGROUND

Launch: LIVE_ENTITY_BACKGROUND
Process start: pool-7-thread-1
Process end: LIVE_ENTITY_BACKGROUND
Post start: LIVE_ENTITY_BACKGROUND

Launch: LIVE_ENTITY_BACKGROUND
Process start: pool-7-thread-1
Process end: LIVE_ENTITY_BACKGROUND
Post start: LIVE_ENTITY_BACKGROUND
Post end: LIVE_ENTITY_BACKGROUND
Post end: LIVE_ENTITY_BACKGROUND
Post end: LIVE_ENTITY_BACKGROUND
Post end: LIVE_ENTITY_BACKGROUND
Post end: LIVE_ENTITY_BACKGROUND

After

• Notice sequential launches, each waiting for the post processing to complete

Launch: LIVE_ENTITY_BACKGROUND
Process start: pool-7-thread-1
Process end: LIVE_ENTITY_BACKGROUND
Post start: LIVE_ENTITY_BACKGROUND
Post end: LIVE_ENTITY_BACKGROUND

Launch: LIVE_ENTITY_BACKGROUND
Process start: pool-7-thread-1
Process end: LIVE_ENTITY_BACKGROUND
Post start: LIVE_ENTITY_BACKGROUND
Post end: LIVE_ENTITY_BACKGROUND

Launch: LIVE_ENTITY_BACKGROUND
Process start: pool-7-thread-1
Process end: LIVE_ENTITY_BACKGROUND
Post start: LIVE_ENTITY_BACKGROUND
Post end: LIVE_ENTITY_BACKGROUND

Launch: LIVE_ENTITY_BACKGROUND
Process start: pool-7-thread-1
Process end: LIVE_ENTITY_BACKGROUND
Post start: LIVE_ENTITY_BACKGROUND
Post end: LIVE_ENTITY_BACKGROUND

Launch: LIVE_ENTITY_BACKGROUND
Process start: pool-7-thread-1
Process end: LIVE_ENTITY_BACKGROUND
Post start: LIVE_ENTITY_BACKGROUND
Post end: LIVE_ENTITY_BACKGROUND

Tests

• Add a manual delay in the code to the call post processing
• Spam call invites
• Notice a crash

Tested devices

• Physical
• Emulator
• OS version(s): 28

[github-actions]

Unit Test Results

122 files  ±0  122 suites  ±0   2m 4s ⏱️ -2s
205 tests ±0  205 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
690 runs  ±0  690 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit c09a93c. ± Comparison against base commit 0325754.

[ganfra]

LGTM, thanks